From 53d183c343392ab6d89a1ad19304694c41a65e54 Mon Sep 17 00:00:00 2001 From: David Cui Date: Thu, 8 Jul 2021 12:20:44 -0700 Subject: [PATCH 1/4] exclude time range check for notebooks reports Signed-off-by: David Cui --- .../public/components/main/report_details/report_details.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dashboards-reports/public/components/main/report_details/report_details.tsx b/dashboards-reports/public/components/main/report_details/report_details.tsx index e79988a3..ff4c6f39 100644 --- a/dashboards-reports/public/components/main/report_details/report_details.tsx +++ b/dashboards-reports/public/components/main/report_details/report_details.tsx @@ -211,7 +211,7 @@ export function ReportDetails(props) { source: reportParams.report_source, // TODO: we have all data needed, time_from, time_to, time_duration, // think of a way to better display - time_period: parseTimePeriod(queryUrl), + time_period: !queryUrl.includes('notebooks-dashboards') ? parseTimePeriod(queryUrl) : '', defaultFileFormat: coreParams.report_format, state: state, reportHeader: From 49e1b4c0d29d50bb1986a1e981794f4e7de29373 Mon Sep 17 00:00:00 2001 From: David Cui Date: Thu, 8 Jul 2021 12:30:24 -0700 Subject: [PATCH 2/4] use report source identifier over url partial match Signed-off-by: David Cui --- .../public/components/main/report_details/report_details.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dashboards-reports/public/components/main/report_details/report_details.tsx b/dashboards-reports/public/components/main/report_details/report_details.tsx index ff4c6f39..8f46940e 100644 --- a/dashboards-reports/public/components/main/report_details/report_details.tsx +++ b/dashboards-reports/public/components/main/report_details/report_details.tsx @@ -211,7 +211,7 @@ export function ReportDetails(props) { source: reportParams.report_source, // TODO: we have all data needed, time_from, time_to, time_duration, // think of a way to better display - time_period: !queryUrl.includes('notebooks-dashboards') ? parseTimePeriod(queryUrl) : '', + time_period: (reportParams.report_source !== 'Notebook') ? parseTimePeriod(queryUrl) : '', defaultFileFormat: coreParams.report_format, state: state, reportHeader: From ed1f7ab9aa61dda023c4655a74b7b4d67bc03337 Mon Sep 17 00:00:00 2001 From: David Cui Date: Thu, 8 Jul 2021 12:52:25 -0700 Subject: [PATCH 3/4] add report details fix to release notes Signed-off-by: David Cui --- .../opensearch-dashboards-reports.release-notes-1.0.0.0.md | 1 + 1 file changed, 1 insertion(+) diff --git a/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md b/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md index 0e97519d..6c5af3bd 100644 --- a/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md +++ b/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md @@ -26,6 +26,7 @@ Compatible with OpenSearch 1.0.0 * Better support sorting for csv report based on saved search ([#86](https://github.com/opensearch-project/dashboards-reports/pull/86)) * bump dependency version ([#101](https://github.com/opensearch-project/dashboards-reports/pull/101)) * fix failed cypress integ-testing ([#106](https://github.com/opensearch-project/dashboards-reports/pull/106)) +* Exclude time range from report details for Notebooks ([#117](https://github.com/opensearch-project/dashboards-reports/pull/117)) ### Infrastructure From ffc34c49e8c95ffd6e84f2ab4b0a625fb0f8d5de Mon Sep 17 00:00:00 2001 From: David Cui Date: Thu, 8 Jul 2021 12:55:49 -0700 Subject: [PATCH 4/4] add more bug fixes to release notes Signed-off-by: David Cui --- .../opensearch-dashboards-reports.release-notes-1.0.0.0.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md b/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md index 6c5af3bd..6a3d8d82 100644 --- a/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md +++ b/release-notes/opensearch-dashboards-reports.release-notes-1.0.0.0.md @@ -26,6 +26,8 @@ Compatible with OpenSearch 1.0.0 * Better support sorting for csv report based on saved search ([#86](https://github.com/opensearch-project/dashboards-reports/pull/86)) * bump dependency version ([#101](https://github.com/opensearch-project/dashboards-reports/pull/101)) * fix failed cypress integ-testing ([#106](https://github.com/opensearch-project/dashboards-reports/pull/106)) +* Fix notebooks context menu ([#109](https://github.com/opensearch-project/dashboards-reports/pull/109)) +* Update context menu download request body after schema change ([#115](https://github.com/opensearch-project/dashboards-reports/pull/115)) * Exclude time range from report details for Notebooks ([#117](https://github.com/opensearch-project/dashboards-reports/pull/117))