Bump version 3.0.0-alpha1-SNAPSHOT #1073
Merged
+127
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sebastian <[email protected]>
paulstn
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Open
6 tasks
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
approved these changes
Feb 26, 2025
joshuali925
approved these changes
Feb 26, 2025
joshuali925
reviewed
Feb 26, 2025
Comment on lines
+310
to
+311
| builder.field(TIME_FROM_TAG, timeFrom) | ||
| builder.field(TIME_TO_TAG, timeTo) |
There was a problem hiding this comment.
if we change it to
Suggested change
| builder.field(TIME_FROM_TAG, timeFrom) | |
| builder.field(TIME_TO_TAG, timeTo) | |
| if (timeFrom != null) builder.field(TIME_FROM_TAG, timeFrom) | |
| if (timeTo != null) builder.field(TIME_TO_TAG, timeTo) |
we won't need to add
although it would be good to cover parsing timeFrom and timeTo in tests
FYI @sumukhswamy
There was a problem hiding this comment.
@sumukhswamy can you please pick up the above suggestion when we add more tests for timeFrom and timeTo
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps plugin version to 3.0.0-alpha1-SNAPSHOT
Related Issues
Resolves #731
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.