Refactor cli

[rupal-bq]

          Minor: I feel the param list is a little bit long, we may consider to refactor it a little bit later.

Originally posted by @mengweieric in #11 (comment)

[rupal-bq]

address following comments in refactor:

• Add self signed certificate for smtp transport option #40 (comment)

Could you try this merge strategy :

const defaults = {
  auth: DEFAULT_AUTH,
  tenant: DEFAULT_TENANT,
  ... (etc)
}

Object.assign(defaults, ...event)
I think would both clarify the defaults, and make the fallback assignments a one-liner.

• Add self signed certificate for smtp transport option #40 (comment)

Might start to make sense to turn this into an object-reference, with an interface. Naming might be hard, though I could make more sense and less brain-power out of arguments named {emailContent, smtpConfig} with associated interfaces.

This would also mean that further config changes (new options) do not cause change on this method (or at least this method signature

• Add self signed certificate for smtp transport option #40 (comment)

This feels like making this module to two different things : 1. format/send email. 2. control UI/UX.

I think the only question in splitting this up would be if there is expected some "on-the-fly" UX while the email-sending process is ongoing... In our modern computing environment, there shouldn't be a timing issue... emails never take > 10sec so send.. or else they fail immediately.

• Add self signed certificate for smtp transport option #40 (comment)

This might be a lot more clear using a try..catch.. .and if necessary a throw on self-detected error (err value is not null?)

[rupal-bq]

• Fix for lambda not evaluating some environment variables #42 (comment)

this works but seems backwards, it's easy to miss since the code is checking process.env[ENV_VAR.EMAIL_NOTE] in both getOptions and getEventArguments. e.g. if a config file is introduced later, this needs to also check && config_file.email_note === undefined

i think peter brought this up before, it might be better to have a default options object in getOptions. If there are any explicitly defined configs, overwrite the value with the highest priority config (command arguments > environment variables), or overwrite multiple times starting from lowest priority