Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Move PPL AST (SQL) and consolidate #25

Open
YANG-DB opened this issue Nov 27, 2024 · 3 comments
Open

[FEATURE]Move PPL AST (SQL) and consolidate #25

YANG-DB opened this issue Nov 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@YANG-DB
Copy link
Member

YANG-DB commented Nov 27, 2024

Is your feature request related to a problem?

This second step of consolidating the PPL spec into a single repository which will be deployed as an independent artifact.

What solution would you like?

Second step:

  • Move PPL AST visitors into this repo
  • consolidate different divergence between SQL's & Spark's PPL AST
  • add as a jar artifact publishing to Maven

#23 - Main RFC

Do you have any additional context?

@andy-k-improving
Copy link

andy-k-improving commented Nov 28, 2024

We should have some guidelines ahead of the implementation, regarding the part of consolidate different divergence between SQL's & Spark's PPL AST
Some divergence I foresee would be:

  • If the PPL command on both sides take the same amount of arguments but in different order, the order from SQL Plugin should be honoured.

  • If arguments are being read differently in terms of type hierarchy, cast up should happen. (Number v.s Integer, Date represent in String format v.s Date)

@YANG-DB
Copy link
Member Author

YANG-DB commented Nov 28, 2024

@andy-k-improving I agree - we need to review each case and determine the differences and see :

  • do they actually matter for the result ?
  • what is the cause of this diff ?
  • is it simple to change to code to overcome this diff OR add the additional dialect layer that would do the translation based on each command (the dialect will have its own grammar file)

@YANG-DB YANG-DB moved this to Design in PPL Commands Nov 28, 2024
@dblock dblock removed the untriaged label Dec 16, 2024
@dblock
Copy link
Member

dblock commented Dec 16, 2024

[Catch All Triage - 1, 2, 3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Design
Development

No branches or pull requests

3 participants