Create conf directory if not exist to avoid NoSuchFile exceptions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
============================================
+ Coverage 71.73% 72.21% +0.48%
- Complexity 337 340 +3
============================================
Files 43 43
Lines 2452 2455 +3
Branches 149 150 +1
============================================
+ Hits 1759 1773 +14
+ Misses 588 577 -11
Partials 105 105
Continue to review full report at Codecov.
|
added 2 commits
May 5, 2021 13:06
khushbr
approved these changes
May 5, 2021
jotok
approved these changes
May 6, 2021
| Path destDir = Paths.get(getDataDirectory()); | ||
| if (!Files.exists(destDir)) { | ||
| StatsCollector.instance() | ||
| .logException(StatExceptionCode.CONFIG_DIR_NOT_FOUND); |
There was a problem hiding this comment.
What level is this logged at (e.g. error, warning)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signoff by: Harold Xiao [email protected]
Describe the solution you are proposing
When running PA unit tests, errors with NoSuchFile exceptions will pop out, the reason is that the path to store the conf files is not exist. This PR add a conditional check to add the directory to avoid the exceptions.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Prerequisite: Add CONFIG_DIR_NOT_FOUND in StatExceptionCode
(https://github.com/opensearch-project/performance-analyzer-rca/pull/11/files)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.