Fix deb, rpm build and remove deb, rpm related files from tar artifacts #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sruti Parthiban <[email protected]>
kjoseph07
approved these changes
Nov 9, 2021
|
Created an issue to track failing upgrade on deb and rpm. |
kjoseph07
added a commit
that referenced
this pull request
Nov 9, 2021
* Change main to 1.2 Signed-off-by: Karishma Joseph <[email protected]> * Fix broken build and remove deb rpm files (#85) Signed-off-by: Sruti Parthiban <[email protected]> Co-authored-by: Sruti Parthiban <[email protected]>
kjoseph07
added a commit
that referenced
this pull request
Nov 10, 2021
* Change main to 1.2 Signed-off-by: Karishma Joseph <[email protected]> * Fix broken build and remove deb rpm files (#85) Signed-off-by: Sruti Parthiban <[email protected]> * Add release notes for 1.2 release Signed-off-by: Karishma Joseph <[email protected]> Co-authored-by: Sruti Parthiban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sruti Parthiban [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#81
Describe the solution you are proposing
Remove packaging deb and rpm related files in tar artifacts.
From opendistro 1.10.1 release the upgrade on deb and rpm is broken. Need to revisit postinst and postrm scripts. As a part of this effort if the deb and rpm files are needed in the install directory, an env variable can be used to filter out the unnecessary files.
opendistro-for-elasticsearch/performance-analyzer#235
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.