Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DCO workflow and fix failing IT #78

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Add DCO workflow and fix failing IT #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/dco.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Developer Certificate of Origin Check

on: [pull_request]

jobs:
check:
runs-on: ubuntu-latest

steps:
- name: Get PR Commits
id: 'get-pr-commits'
uses: tim-actions/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: DCO Check
uses: tim-actions/[email protected]
with:
commits: ${{ steps.get-pr-commits.outputs.commits }}
2 changes: 1 addition & 1 deletion licenses/performanceanalyzer-rca-1.2.0.0-SNAPSHOT.jar.sha1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7bc66e87081fe6991129463a019d4c118996841c
7bc66e87081fe6991129463a019d4c118996841c
20 changes: 12 additions & 8 deletions src/test/java/org/opensearch/performanceanalyzer/ConfigOverridesIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,18 @@ public class ConfigOverridesIT extends PerformanceAnalyzerIntegTestBase {

@Test
public void testSimpleOverride() throws Exception {
testSimpleOverride(CONFIG_OVERRIDES_ENDPOINT);
testSimpleOverride(RestConfig.PA_BASE_URI, CONFIG_OVERRIDES_ENDPOINT);
}

@Test
public void testLegacySimpleOverride() throws Exception {
testSimpleOverride(LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
testSimpleOverride(
RestConfig.LEGACY_PA_BASE_URI, LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
}

public void testSimpleOverride(String configOverridesEndpoint) throws Exception {
ensurePaAndRcaEnabled(configOverridesEndpoint);
public void testSimpleOverride(String paBaseUri, String configOverridesEndpoint)
throws Exception {
ensurePaAndRcaEnabled(paBaseUri);
final ConfigOverrides overrides =
getOverrides(
Arrays.asList(HOT_SHARD_RCA, HOT_NODE_CLUSTER_RCA),
Expand Down Expand Up @@ -106,16 +108,18 @@ public void testSimpleOverride(String configOverridesEndpoint) throws Exception

@Test
public void testCompositeOverrides() throws Exception {
testCompositeOverrides(CONFIG_OVERRIDES_ENDPOINT);
testCompositeOverrides(RestConfig.PA_BASE_URI, CONFIG_OVERRIDES_ENDPOINT);
}

@Test
public void testLegacyCompositeOverrides() throws Exception {
testCompositeOverrides(LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
testCompositeOverrides(
RestConfig.LEGACY_PA_BASE_URI, LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
}

public void testCompositeOverrides(String configOverridesEndpoint) throws Exception {
ensurePaAndRcaEnabled(configOverridesEndpoint);
public void testCompositeOverrides(String paBaseUri, String configOverridesEndpoint)
throws Exception {
ensurePaAndRcaEnabled(paBaseUri);

final ConfigOverrides initialOverrides =
getOverrides(
Expand Down