-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that PATransportChannel delegates to wrapped channel and add tests #609
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
============================================
- Coverage 70.88% 69.37% -1.51%
+ Complexity 421 374 -47
============================================
Files 49 44 -5
Lines 3125 2691 -434
Branches 194 172 -22
============================================
- Hits 2215 1867 -348
+ Misses 785 721 -64
+ Partials 125 103 -22 ☔ View full report in Codecov by Sentry. |
The BWC tests are failing, can you bump up the BWC version to 2.11 here: https://github.com/opensearch-project/performance-analyzer/blob/main/build.gradle#L13. The same needs to be back-ported to 2.x branch. |
@cwperks want to finish this? |
Rebased with main. @Gaganjuneja @psychbot Can you take a look? |
@Gaganjuneja This would be another good one to close the loop on for this repo. Thank you for your help today :) |
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Ensures that PATransportChannel delegates implementations to the wrapped channel except for:
Added tests that use reflection to ensure that if the TransportChannel interface changes that the CI in this repo catches it to ensure that this wrapper class gets modified accordingly.
Additional context
#606
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.