Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that PATransportChannel delegates to wrapped channel and add tests #609

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Dec 7, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

Ensures that PATransportChannel delegates implementations to the wrapped channel except for:

  • getChannelType
  • getProfileName

Added tests that use reflection to ensure that if the TransportChannel interface changes that the CI in this repo catches it to ensure that this wrapper class gets modified accordingly.

Additional context

#606

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (9cb092f) to head (e5bfb28).
Report is 1 commits behind head on main.

Current head e5bfb28 differs from pull request most recent head c9edae1

Please upload reports for the commit c9edae1 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #609      +/-   ##
============================================
- Coverage     70.88%   69.37%   -1.51%     
+ Complexity      421      374      -47     
============================================
  Files            49       44       -5     
  Lines          3125     2691     -434     
  Branches        194      172      -22     
============================================
- Hits           2215     1867     -348     
+ Misses          785      721      -64     
+ Partials        125      103      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khushbr
Copy link
Collaborator

khushbr commented Dec 8, 2023

The BWC tests are failing, can you bump up the BWC version to 2.11 here: https://github.com/opensearch-project/performance-analyzer/blob/main/build.gradle#L13. The same needs to be back-ported to 2.x branch.

@dblock
Copy link
Member

dblock commented Jun 6, 2024

@cwperks want to finish this?

@cwperks
Copy link
Member Author

cwperks commented Jun 25, 2024

Rebased with main. @Gaganjuneja @psychbot Can you take a look?

@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024

@Gaganjuneja This would be another good one to close the loop on for this repo. Thank you for your help today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants