Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions by legacy cluster endpoints #21

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Jun 1, 2021

Signed-off-by: Sruti Parthiban [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#20

Describe the solution you are proposing
Fix the actions performed by the legacy API.

[root@e2eba3ca732e opensearch]# curl localhost:9200/_opendistro/_performanceanalyzer/rca/cluster/config -H 'Content-Type: application/json' -d '{"enabled": true}'
{"currentPerformanceAnalyzerClusterState":1,"shardsPerCollection":0,"batchMetricsRetentionPeriodMinutes":7}[root@e2eba3ca732e opensearch]# 
[root@e2eba3ca732e opensearch]# 
[root@e2eba3ca732e opensearch]# curl -XGET http://localhost:9200/_opendistro/_performanceanalyzer/cluster/config
{"currentPerformanceAnalyzerClusterState":3,"shardsPerCollection":0,"batchMetricsRetentionPeriodMinutes":7}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sruti1312 sruti1312 requested a review from jotok June 1, 2021 21:17
Copy link
Collaborator

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Sruti Parthiban <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #21 (a6fabc7) into main (762286f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head a6fabc7 differs from pull request most recent head 9211665. Consider uploading reports for the commit 9211665 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #21      +/-   ##
============================================
- Coverage     72.21%   72.13%   -0.09%     
- Complexity      348      349       +1     
============================================
  Files            44       44              
  Lines          2473     2476       +3     
  Branches        155      158       +3     
============================================
  Hits           1786     1786              
- Misses          584      585       +1     
- Partials        103      105       +2     
Impacted Files Coverage Δ
...config/PerformanceAnalyzerClusterConfigAction.java 87.23% <100.00%> (+0.87%) ⬆️
...ormanceanalyzer/writer/EventLogQueueProcessor.java 58.33% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762286f...9211665. Read the comment docs.

@sruti1312 sruti1312 merged commit 1357d86 into main Jun 1, 2021
@sruti1312 sruti1312 deleted the partsrut-cluster-config branch June 1, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants