Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logs for Integration Tests #182

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Apr 7, 2022

Signed-off-by: sruti1312 [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#170

Describe the solution you are proposing
Add additional logs for Integration Tests

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sruti1312 <[email protected]>
@sruti1312 sruti1312 requested a review from a team April 7, 2022 18:42
@sruti1312 sruti1312 force-pushed the feature/add-additional-logs branch from db981d9 to 81fd4e3 Compare April 8, 2022 17:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #182 (bd3e53d) into main (340f11e) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head bd3e53d differs from pull request most recent head 81fd4e3. Consider uploading reports for the commit 81fd4e3 to get more accurate results

@@             Coverage Diff              @@
##               main     #182      +/-   ##
============================================
- Coverage     71.77%   71.69%   -0.09%     
  Complexity      356      356              
============================================
  Files            44       44              
  Lines          2459     2459              
  Branches        160      160              
============================================
- Hits           1765     1763       -2     
- Misses          588      589       +1     
- Partials        106      107       +1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 55.95% <0.00%> (-4.77%) ⬇️
...analyzer/collectors/MasterServiceEventMetrics.java 73.64% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340f11e...81fd4e3. Read the comment docs.

dzane17
dzane17 previously approved these changes Apr 8, 2022
@@ -381,10 +381,10 @@ task buildRca() {
exec {
workingDir("$rcaProjectDir")
if (buildVersionQualifier == null || buildVersionQualifier == '' || buildVersionQualifier == 'null') {
commandLine './gradlew', 'build', '-x', 'test', "-Dopensearch.version=${opensearch_version}", "-Dbuild.snapshot=${isSnapshot}"
commandLine './gradlew', 'build', '-x', 'test', '-x', 'jacocoTestCoverageVerification', "-Dopensearch.version=${opensearch_version}", "-Dbuild.snapshot=${isSnapshot}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess added my mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As tests are excluded, the jacocoTestCoverageVerification task should also be ignored.

@sruti1312 sruti1312 requested a review from sgup432 April 8, 2022 20:24
@sruti1312 sruti1312 merged commit 9d81bd6 into main Apr 8, 2022
@sruti1312 sruti1312 deleted the feature/add-additional-logs branch April 8, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants