Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jackson version to 2.11.4 #13

Merged
merged 3 commits into from
May 19, 2021
Merged

Upgrade Jackson version to 2.11.4 #13

merged 3 commits into from
May 19, 2021

Conversation

jotok
Copy link
Contributor

@jotok jotok commented May 19, 2021

Upgrade Jackson version to 2.11.4 to match OpenSearch core.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-28491

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The older version of Jackson was flagged in the linked CVE.

Describe the solution you are proposing
Upgrade to a later version not affect by the CVE. The version 2.11.4 is chosen to match OpenSearch core.

Describe alternatives you've considered
We could upgrade to a later version of Jackson, but I think it makes sense to match OpenSearch core to avoid any compatibility bugs. Note that the CVE does not apply to versions 2.11.4 and later.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #13 (deaf4bf) into main (ee24037) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #13      +/-   ##
============================================
- Coverage     72.24%   72.12%   -0.12%     
+ Complexity      340      339       -1     
============================================
  Files            43       43              
  Lines          2457     2461       +4     
  Branches        150      150              
============================================
  Hits           1775     1775              
- Misses          577      582       +5     
+ Partials        105      104       -1     
Impacted Files Coverage Δ Complexity Δ
...earch/performanceanalyzer/OpenSearchResources.java 97.36% <ø> (ø) 19.00 <0.00> (?)
...performanceanalyzer/PerformanceAnalyzerPlugin.java 76.19% <ø> (ø) 11.00 <0.00> (?)
...alyzer/action/PerformanceAnalyzerActionFilter.java 96.87% <ø> (ø) 6.00 <0.00> (?)
...yzer/action/PerformanceAnalyzerActionListener.java 96.87% <ø> (ø) 10.00 <0.00> (?)
...search/performanceanalyzer/action/RequestType.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...r/collectors/AdmissionControlMetricsCollector.java 7.04% <ø> (ø) 3.00 <0.00> (?)
...alyzer/collectors/CacheConfigMetricsCollector.java 84.31% <ø> (ø) 7.00 <0.00> (?)
...ceanalyzer/collectors/CircuitBreakerCollector.java 94.11% <ø> (ø) 6.00 <0.00> (?)
...ollectors/ClusterApplierServiceStatsCollector.java 78.66% <ø> (ø) 10.00 <0.00> (?)
...anceanalyzer/collectors/ElectionTermCollector.java 76.31% <ø> (ø) 6.00 <0.00> (?)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb34f28...deaf4bf. Read the comment docs.

@sruti1312 sruti1312 requested a review from yujias0706 May 19, 2021 20:10
@jotok jotok merged commit 67d4ab7 into main May 19, 2021
@jotok jotok deleted the upgrade-jackson-2-11-4 branch May 19, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants