Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the "Master" nomenclature #152

Closed
12 tasks
Tracked by #2589 ...
tlfeng opened this issue Mar 4, 2022 · 5 comments
Closed
12 tasks
Tracked by #2589 ...

Deprecate the "Master" nomenclature #152

tlfeng opened this issue Mar 4, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@tlfeng
Copy link

tlfeng commented Mar 4, 2022

Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472, with the plan for its terminology replacement.

Although the existing usages with "master" will be supported in OpenSearch version 2.x to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
All the OpenSearch REST APIs and settings that contain "master" terminology will be deprecated in 2.0, and alternative usages will be added.

Describe the solution you'd like
Replace the terminology "master" with "cluster manager".

When being compatible with OpenSearch 2.0:

  • Replace "master" in code comment and internal variable / class name.
    • public class MasterServiceEventMetricsTests
    • import org.opensearch.performanceanalyzer.metrics.AllMetrics.MasterPendingTaskDimension
    • import org.opensearch.performanceanalyzer.metrics.AllMetrics.MasterPendingValue
    • DiscoveryNode masterNode = discoveryNodes.getMasterNode()
    • public class MasterThrottlingMetricsCollectorTests
    • private static final int MASTER_METRICS_ERRORS
    • import org.opensearch.performanceanalyzer.collectors.MasterServiceEventMetrics
    • import org.opensearch.performanceanalyzer.collectors.MasterThrottlingMetricsCollector

When being compatible with OpenSearch 3.0:

  • Replace "master" in the reference to OpenSearch Java API
    (All new APIs below are available in version 2.2)
    • import org.opensearch.cluster.service.MasterService -> import org.opensearch.cluster.service.ClusterManagerService
    • discoveryNodes.getMasterNode() -> discoveryNodes.getClusterManagerNode()
    • DiscoveryNodeRole.MASTER_ROLE -> DiscoveryNodeRole.CLUSTER_MANAGER_ROLE
    • discoBuilder.masterNodeId(nodeId1) -> discoBuilder.clusterManagerNodeId(nodeId1)

Describe alternatives you've considered
None.

Additional context

@tlfeng tlfeng added the enhancement New feature or request label Mar 4, 2022
@dblock dblock changed the title Change the "Master" nomenclature Deprecate the "Master" nomenclature Apr 18, 2022
@dblock dblock added the v2.0.0 label Apr 18, 2022
@dblock
Copy link
Member

dblock commented Apr 18, 2022

For 2.0, at a minimum please ensure that the plugin is not calling any deprecated APIs in core or another plugin, and confirm below, then remove the 2.0.0 label. If you have time, do the complete deprecation as described in this issue.

@sruti1312
Copy link
Contributor

PA does not call any deprecated API's in core or another plugin.

@anasalkouz
Copy link
Member

@sruti1312 @kaushalmahi12
Is there any remaining effort in this task? if not, please close the issue

@anasalkouz anasalkouz added v2.4.0 'Issues and PRs related to version v2.4.0' and removed v3.0.0 labels Sep 15, 2022
@anasalkouz
Copy link
Member

@kaushalmahi12 I saw one PR merged. can you close this issue?

@kaushalmahi12
Copy link
Contributor

The changes are merged. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

No branches or pull requests

5 participants