Fixing Event Log file cleanup issue #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem?
Issue : #26
Previous PR [now closed] : opensearch-project/performance-analyzer#36
PA side PR : opensearch-project/performance-analyzer#36
Describe the solution you are proposing
deleteFiles()
[taken from MetricsPurgeActivity] to clean up the old event log files and then writes the latest event log file. This ensures that we never run into issue of lingering files as the 'EventLogQueueProcessor' will first perform the cleanup before writing new files.MetricConfig
classDescribe alternatives you've considered
Another approach was to launch a new thread and invoke 'MetricsPurgeActivity' within it. We will again run into the same issue if this thread dies, thus to keep the cleanup and write within same thread was better.
Testing
Tested by spinning up a docker container. Manually copied 100 dummy files to
/dev/shm/performanceanalyzer/
.Enabled DEBUG logs to verify cleanup is working as expected
Metrics:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.