Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize processes across all plugins - Checklist items #22

Merged
merged 7 commits into from
Jun 29, 2021

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Jun 25, 2021

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
opensearch-project/performance-analyzer#25

Describe the solution you are proposing
Standardize processes across all plugins

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sruti1312 sruti1312 changed the title Feature/checklist items Standardize processes across all plugins - Checklist items Jun 25, 2021
Copy link
Collaborator

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sruti1312 sruti1312 requested a review from jotok June 25, 2021 23:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2021

Codecov Report

Merging #22 (9a40d0d) into main (1ee100d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9a40d0d differs from pull request most recent head bc1510d. Consider uploading reports for the commit bc1510d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #22      +/-   ##
============================================
+ Coverage     76.89%   76.91%   +0.01%     
+ Complexity     3182     3176       -6     
============================================
  Files           368      368              
  Lines         18366    18366              
  Branches       1396     1396              
============================================
+ Hits          14123    14126       +3     
+ Misses         3748     3744       -4     
- Partials        495      496       +1     
Impacted Files Coverage Δ
...ensearch/performanceanalyzer/CertificateUtils.java 84.74% <0.00%> (-6.78%) ⬇️
...ormanceanalyzer/rca/store/rca/cache/CacheUtil.java 61.29% <0.00%> (-3.23%) ⬇️
...ensearch/performanceanalyzer/hwnet/NetworkE2E.java 77.47% <0.00%> (-1.81%) ⬇️
...ceanalyzer/rca/framework/util/InstanceDetails.java 79.68% <0.00%> (-1.57%) ⬇️
...performanceanalyzer/net/GRPCConnectionManager.java 86.36% <0.00%> (-1.14%) ⬇️
...erformanceanalyzer/rca/framework/core/RcaConf.java 64.53% <0.00%> (+1.41%) ⬆️
...nsearch/performanceanalyzer/rca/RcaController.java 85.20% <0.00%> (+1.79%) ⬆️
...nalyzer/rca/net/handler/PublishRequestHandler.java 85.36% <0.00%> (+2.43%) ⬆️
...g/opensearch/performanceanalyzer/os/OSGlobals.java 63.41% <0.00%> (+7.31%) ⬆️
...performanceanalyzer/rca/framework/api/Symptom.java 100.00% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee100d...bc1510d. Read the comment docs.

@sruti1312 sruti1312 merged commit 8679c2b into main Jun 29, 2021
@sruti1312 sruti1312 deleted the feature/checklist-items branch June 29, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants