Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HTTP contexts for legacy resource name #18

Merged
merged 2 commits into from
May 24, 2021
Merged

Conversation

jotok
Copy link
Contributor

@jotok jotok commented May 22, 2021

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
We want the Performance Analyzer agent API for OpenSearch to be backward compatible with OpenDistro.

Describe the solution you are proposing
Adding HttpContexts that will resolve the old /_opendistro resource name.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sruti1312
Copy link
Contributor

There is also the RCA API in 9600 port. Maybe we need to update that as well? Or, does this cover that?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@30b53ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage        ?   76.99%           
  Complexity      ?     3182           
=======================================
  Files           ?      368           
  Lines           ?    18360           
  Branches        ?     1396           
=======================================
  Hits            ?    14136           
  Misses          ?     3732           
  Partials        ?      492           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b53ae...6b9997d. Read the comment docs.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests and, if possible, to mark the old route deprecated.

@jotok jotok requested a review from dblock May 24, 2021 23:21
@jotok jotok merged commit c15f5c8 into main May 24, 2021
@jotok jotok deleted the rest-backward-compat branch May 24, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants