Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory names #166

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Update directory names #166

merged 2 commits into from
Apr 15, 2022

Conversation

sruti1312
Copy link
Contributor

Signed-off-by: sruti1312 [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
Update directory names

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sruti1312 <[email protected]>
@sruti1312 sruti1312 requested a review from a team April 15, 2022 18:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #166 (221dc30) into main (5373ddb) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #166      +/-   ##
============================================
- Coverage     71.78%   71.38%   -0.40%     
+ Complexity     2951     2936      -15     
============================================
  Files           376      376              
  Lines         18765    18765              
  Branches       1445     1445              
============================================
- Hits          13470    13396      -74     
- Misses         4700     4778      +78     
+ Partials        595      591       -4     
Impacted Files Coverage Δ
...rch/performanceanalyzer/config/PluginSettings.java 28.74% <ø> (-1.20%) ⬇️
...opensearch/performanceanalyzer/jvm/ThreadList.java 12.03% <ø> (ø)
...formanceanalyzer/rca/framework/util/RcaConsts.java 89.47% <100.00%> (ø)
...ensearch/performanceanalyzer/CertificateUtils.java 23.72% <0.00%> (-61.02%) ⬇️
...formanceanalyzer/PerformanceAnalyzerWebServer.java 16.41% <0.00%> (-52.24%) ⬇️
...ensearch/performanceanalyzer/hwnet/NetworkE2E.java 77.47% <0.00%> (-1.81%) ⬇️
...nsearch/performanceanalyzer/rca/RcaController.java 79.29% <0.00%> (-1.77%) ⬇️
...performanceanalyzer/collectors/StatsCollector.java 92.48% <0.00%> (-0.76%) ⬇️
.../org/opensearch/performanceanalyzer/core/Util.java 70.83% <0.00%> (+8.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5373ddb...221dc30. Read the comment docs.

dzane17
dzane17 previously approved these changes Apr 15, 2022
@kjoseph07 kjoseph07 self-requested a review April 15, 2022 21:13
@sruti1312 sruti1312 merged commit c020cc9 into main Apr 15, 2022
@sruti1312 sruti1312 deleted the feature/rename-folder branch April 15, 2022 21:16
sruti1312 added a commit that referenced this pull request May 11, 2022
sruti1312 added a commit that referenced this pull request May 17, 2022
* Update folder names (#166)

Signed-off-by: sruti1312 <[email protected]>

* Update PA directories from plugins to root (#168)

Signed-off-by: sruti1312 <[email protected]>

* Update configFilePath location (#172)

Signed-off-by: sruti1312 <[email protected]>

* Disable plugin if configFilePath is not present (#173)

Signed-off-by: sruti1312 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants