Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing metrics which are not required now as were removed in OS 2.0 #159

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Apr 7, 2022

Signed-off-by: Sagar Upadhyaya [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Removing segment related memory metrics as they were removed from OS 2.0 here - opensearch-project/OpenSearch@fc0d3a3.

We had removed references of these in PA as well earlier.

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sgup432 sgup432 requested review from a team, dzane17 and sruti1312 April 7, 2022 19:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #159 (5c19cec) into main (99d6d42) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5c19cec differs from pull request most recent head 5e4eb15. Consider uploading reports for the commit 5e4eb15 to get more accurate results

@@             Coverage Diff              @@
##               main     #159      +/-   ##
============================================
- Coverage     71.93%   71.89%   -0.05%     
- Complexity     2949     2951       +2     
============================================
  Files           376      376              
  Lines         18782    18747      -35     
  Branches       1442     1442              
============================================
- Hits          13511    13478      -33     
  Misses         4675     4675              
+ Partials        596      594       -2     
Impacted Files Coverage Δ
...opensearch/performanceanalyzer/jvm/ThreadList.java 12.34% <ø> (ø)
...search/performanceanalyzer/metrics/AllMetrics.java 86.47% <ø> (-0.16%) ⬇️
...search/performanceanalyzer/model/MetricsModel.java 100.00% <ø> (ø)
...nceanalyzer/rca/store/OpenSearchAnalysisGraph.java 100.00% <ø> (ø)
...performanceanalyzer/collectors/StatsCollector.java 93.23% <0.00%> (+0.75%) ⬆️
...nalyzer/rca/net/handler/PublishRequestHandler.java 87.75% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d6d42...5e4eb15. Read the comment docs.

@sruti1312
Copy link
Contributor

Documentation needs to be updated that these metrics are not supported.
https://opendistro.github.io/for-elasticsearch-docs/docs/pa/reference/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants