Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #293

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 6 comments · Fixed by #302 or #313
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #293

dblock opened this issue Feb 14, 2023 · 6 comments · Fixed by #302 or #313
Assignees

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@dblock
Copy link
Member Author

dblock commented Mar 9, 2023

You have the performance analyzer team with 13 members that have maintain access to this repo and a plugins team with 8 members that has admin access. Only folks listed in MAINTAINERS/CODEOWNERS need to have maintain access, and groups don't support external collaborators and therefore should be removed except for admin. Please work with an admin to remove the group, and add individuals.

@dblock dblock reopened this Mar 9, 2023
@kkhatua
Copy link
Member

kkhatua commented Mar 9, 2023

@dblock there is a Maintainer tag in the team. Shouldn't that be what is reflected in the CODEOWNERS and MAINTAINERS?
The performance analyzer team has folks with committer access so as to reduce the load and improving response time; and we are following the requisite review process of minimum of 2 votes.
(Tagging @praveensameneni )

@kkhatua kkhatua assigned praveensameneni and unassigned dzane17 Mar 9, 2023
@praveensameneni
Copy link
Member

We got the required number of votes to add new members to the MAINTAINERS list. Will update.

@dblock
Copy link
Member Author

dblock commented Apr 4, 2023

The permissions are incorrect. Please work with an admin to remove both the PA and plugin teams and add individuals from MAINTAINERS.
Screenshot 2023-04-04 at 12 12 52 PM

@gaiksaya
Copy link
Member

Permissions updated for this repo as per the maintainers list:
image

@praveensameneni @khushbr Please verify!

Thanks!

@khushbr khushbr closed this as completed Apr 24, 2023
@dblock
Copy link
Member Author

dblock commented Apr 27, 2023

Verified, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants