Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text and highlight color of OuiCollapsableNav #955

Closed
Tracked by #895
joshuarrrr opened this issue Aug 9, 2023 · 2 comments · Fixed by #973
Closed
Tracked by #895

Update text and highlight color of OuiCollapsableNav #955

joshuarrrr opened this issue Aug 9, 2023 · 2 comments · Fixed by #973
Assignees

Comments

@joshuarrrr
Copy link
Member

No description provided.

@KrooshalUX
Copy link
Contributor

@joshuarrrr this might not be necessary depending on how #904 turns out.

@joshuarrrr joshuarrrr moved this from UX Required to Blocked in Look & Feel Aug 10, 2023
@joshuarrrr joshuarrrr moved this from Blocked to In Progress in Look & Feel Aug 10, 2023
@joshuarrrr joshuarrrr moved this from In Progress to Todo in Look & Feel Aug 10, 2023
@joshuarrrr joshuarrrr assigned joshuarrrr and unassigned BSFishy Aug 10, 2023
@joshuarrrr joshuarrrr moved this from Todo to Blocked in Look & Feel Aug 15, 2023
@joshuarrrr
Copy link
Member Author

joshuarrrr commented Aug 16, 2023

One of the weird implementation quirks of OuiCollapsibleNav and OuiCollapsibleNavGroup is that there's no attempt to guarantee contrast ratio of text. The prop description for background explicitly notes that only the title text color is adjusted to the background:

/**
* Adds a background color to the entire group,
* applying the correct text color to the `title` only
*/
background?: Background;

Instead, the color prop of OuiText is generally used as-is, and most of the example snippets in the OUI doc site extensively use subdued.

So we can either make sure that <OuiText color="subdued"> is generally smarter and "background-aware", or else make sure it has high enough contrast against any of the OuiCollapsibleNavGroup backgrounds. The latter approach may be the way we go with #938

@joshuarrrr joshuarrrr moved this from Blocked to Todo in Look & Feel Aug 16, 2023
@joshuarrrr joshuarrrr moved this from Todo to UX Required in Look & Feel Aug 16, 2023
@github-project-automation github-project-automation bot moved this from UX Required to Done in Look & Feel Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants