Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accordions support #944

Open
Tracked by #4654
lezzago opened this issue Aug 1, 2023 · 4 comments
Open
Tracked by #4654

Improved accordions support #944

lezzago opened this issue Aug 1, 2023 · 4 comments
Labels

Comments

@lezzago
Copy link
Member

lezzago commented Aug 1, 2023

Is your feature request related to a problem? Please describe.

For the Alerts/Anomalies on Dashboard visualizations feature, we required an enhanced and minimal version of the accordions for the flyouts we created on the Dashboard page.

Describe the solution you'd like

The Enhanced and minimal accordion experience can be seen here: opensearch-project/alerting-dashboards-plugin#483

This has been implemented in Alerting with the following code: https://github.com/opensearch-project/alerting-dashboards-plugin/tree/main/public/components/FeatureAnywhereContextMenu/EnhancedAccordion

The part for a minimal accordion is done here: https://github.com/opensearch-project/alerting-dashboards-plugin/tree/main/public/components/FeatureAnywhereContextMenu/MinimalAccordion

@lezzago lezzago added the enhancement New feature or request label Aug 1, 2023
@lezzago
Copy link
Member Author

lezzago commented Aug 1, 2023

@xeniatup to help drive the requirements for the

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Aug 1, 2023

@xeniatup @lezzago is this related to the proposed component OuiAccordionCard ? If so, we have this meta issue that is blocked pending the final generalized designs of the component. @xeniatup - lets formalize a timeline for the component design including all necessary states and builder options.

@lezzago
Copy link
Member Author

lezzago commented Aug 1, 2023

@KrooshalUX I believe this should be related to the OuiAccordionCard. We can use the usecases for this to help drive more requirements for the OuiAccordionCard then.

@KrooshalUX
Copy link
Contributor

@lezzago excellent. I have included this in the meta issue to drive the details. Thanks! Really excited for this component to be added to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants