-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance OUIBetaBadge for experimental releases #93
Comments
I really like this for Experimental features. I'm not opposed to keeping the |
(In fact, i prefer it to |
@kgcreative the idea is to enhance this for Experimental so we can use the lab or "beaker" icon on small components (like tables cells). I have given guidance in opensearch-project/ux#49 to replace the "E" with |
@kaddy645 can you weigh in on the last to-do of this list about naming? |
For the last item, I don't think we need a completely separate component. The beta badge currently expects a |
@BSFishy the last item has to do with aliasing and implementation. We do not want designers or builders using "beta", we want them to use "experimental". That is why I want to make the change to the component itself vs relying on the implementer to change beta to experimental (different task item). For naming - right now OSD & plug-ins can call EuiBetaBadge which because it's aliased will then actually call OuiBetaBadge - but since we want to move away from "Beta" language we need to either map EuiBetaBadge to OuiExperimentalBadge or allow EuiBetaBadge to be called which points to OuiBetaBadge which contains the changes as well and allow OuiExperimentalBadge to be called when OUI is used directly. I am not sure what is involved in a change like this when we need to change the name of a component for clarity. |
We need to decide on how we want to go about releasing these changes before everything gets merged, correct? I am good with the plan to introduce OuiExperimentalBadge and deprecate OuiBetaBadge, but not sure what is involved in that process. Can someone please outline next steps? @AMoo-Miki @BSFishy @kaddy645 ? |
Yes, some of these changes are potentially breaking, warranting a major version bump.
Here's how I think versions will need to be bumped for these merges:
@AMoo-Miki can confirm this and discuss how we can go about merging these for proper version bumping |
@BSFishy One last change has occurred to me, we do not want to use the "E" abbreviated version, only "experimental" or the beaker version (updated issue to-do list). So, we need to make an additional breaking change to remove that option as well. |
@BSFishy please don't remove the existing component in the 1.0; (1) create a new component, even if it is identical to the old one + name change, (2) mark the beta one deprecated and include it in the changelog as being deprecated. When OUI 2 is being released, we would simply delete the beta one. |
Closing in favor of issue #161 |
Change label inside tooltip to "experimental"
Remove option for "E"
Remove styling option "accent"
Identify how introduce the name OuiExperimentalBadge and if OuiBetaBadge and OuiExperimentalBadge can be used interchangeably
The text was updated successfully, but these errors were encountered: