Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logoOpenSearch (OUI Icon version) should change appearance depending on light/dark mode #905

Open
2 tasks
Tracked by #895
KrooshalUX opened this issue Jul 20, 2023 · 7 comments
Open
2 tasks
Tracked by #895
Assignees

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Jul 20, 2023

https://oui.opensearch.org/1.2/#/display/icons#opensearch-logos

Change within component and in OUI Docs site:

  • OuiHeader
  • OuiLoadingDashboards

opensearch_darkmode

@joshuarrrr
Copy link
Member

OpenSearch logo? I think we'll need screenshots here to make sure we account for it everywhere it matters.

@AMoo-Miki AMoo-Miki self-assigned this Jul 27, 2023
@KrooshalUX KrooshalUX changed the title OUI Logo should change appearance depending on light/dark mode OpenSearch Logo should change appearance depending on light/dark mode Jul 27, 2023
@KrooshalUX
Copy link
Contributor Author

@joshuarrrr if we can control it through utilizing the logoOpenSearch if possible, I think that would resolve many issues. I am not sure if this is going to require a campaign across the feature plug-ins or not, though, since in some instances they may be using additional OpenSearch logo assets.

@KrooshalUX KrooshalUX changed the title OpenSearch Logo should change appearance depending on light/dark mode logoOpenSearch (OUI Icon version) should change appearance depending on light/dark mode Jul 31, 2023
@joshuarrrr
Copy link
Member

Oh, so this issue is just for OUI doc site? Yeah, shouldn't be a problem.

@KrooshalUX
Copy link
Contributor Author

No, sorry I see how the wording might be confusing. The change is to make logoOpenSearch as an icon change depending on light or dark mode. That way when anyone in OSD uses logoOpenSearch , the change is automatic.

Ideally we would campaign all non OUI driven uses of logoOpenSearch to be OUI driven. (And also adding the full logo as well). This is how EUI served up logos in the past for Kbn.

The changes also need to update in the doc site as well (ex: the logo in the nav bar)

@joshuarrrr joshuarrrr moved this to In Progress in Look & Feel Aug 9, 2023
@joshuarrrr joshuarrrr assigned joshuarrrr and unassigned AMoo-Miki Aug 9, 2023
@joshuarrrr
Copy link
Member

@KrooshalUX - @AMoo-Miki and I discussed this morning, and what we propose is actually providing 3 logoOpenSearch variants - one that's monochrome and is compatible with the color prop that all other icons can use, and then separate logoOpenSearchLight and logoOpenSearchDark variants that use the appropriate fill colors. The reason is that usage doesn't actually depend on theme/mode, but on the background color the icon is set against, such as the OUI docs site where the header always uses the dark background, regardless of theme/mode.

@KrooshalUX
Copy link
Contributor Author

That makes sense to me - is there much risk to the logo being misused/ overrides giving the logo color incorrectly if we are providing it as monocrhome and compatible with the color prop?

@AMoo-Miki
Copy link
Collaborator

Coloring the monochrome ones would only be able to set the entire logo into a specific color; I am having a hard time making up an abusive single color; misuse per the usage guidance for contrasting background would be possible but I don't believe OUI should concern itself with that much detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants