-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logoOpenSearch (OUI Icon version) should change appearance depending on light/dark mode #905
Comments
OpenSearch logo? I think we'll need screenshots here to make sure we account for it everywhere it matters. |
@joshuarrrr if we can control it through utilizing the logoOpenSearch if possible, I think that would resolve many issues. I am not sure if this is going to require a campaign across the feature plug-ins or not, though, since in some instances they may be using additional OpenSearch logo assets. |
Oh, so this issue is just for OUI doc site? Yeah, shouldn't be a problem. |
No, sorry I see how the wording might be confusing. The change is to make logoOpenSearch as an icon change depending on light or dark mode. That way when anyone in OSD uses logoOpenSearch , the change is automatic. Ideally we would campaign all non OUI driven uses of logoOpenSearch to be OUI driven. (And also adding the full logo as well). This is how EUI served up logos in the past for Kbn. The changes also need to update in the doc site as well (ex: the logo in the nav bar) |
@KrooshalUX - @AMoo-Miki and I discussed this morning, and what we propose is actually providing 3 |
That makes sense to me - is there much risk to the logo being misused/ overrides giving the logo color incorrectly if we are providing it as monocrhome and compatible with the color prop? |
Coloring the monochrome ones would only be able to set the entire logo into a specific color; I am having a hard time making up an abusive single color; misuse per the usage guidance for contrasting background would be possible but I don't believe OUI should concern itself with that much detail. |
https://oui.opensearch.org/1.2/#/display/icons#opensearch-logos
Change within component and in OUI Docs site:
The text was updated successfully, but these errors were encountered: