Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate panelled prop of OuiPageBody #843

Open
joshuarrrr opened this issue Jun 22, 2023 · 3 comments
Open

Deprecate panelled prop of OuiPageBody #843

joshuarrrr opened this issue Jun 22, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 22, 2023

@KrooshalUX would prefer to simplify layout guidance and variability by removing this as an option. We can also do a global code search to check for existing usage.

See also #840

@BSFishy
Copy link
Contributor

BSFishy commented Jun 22, 2023

Adding useDeprecatedProps will create log messages where it's used. That can help find some high impact areas

@BSFishy BSFishy added good first issue Good for newcomers and removed untriaged labels Jun 22, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Sep 29, 2023

This work consists of 3 parts:

  1. Insert the useDeprecatedProps hook to generate a console.log message when the prop is used:
    export const useDeprecatedPropWarning = ({

    You can say it will be removed in 2.0.0 (specify the prop version: '2.0.0')
  2. Add a deprecation comment to the prop that says this prop is deprecated and will be removed in version 2.0

If you need any more info or get stuck, feel free to ping me.

Edit: It looks like there isn't any docsite section that discusses this, so only these two are needed

@NishantSinghal19
Copy link
Contributor

@BSFishy can you please assign me this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants