Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [CCI] README Opensearch Logo missing #564

Closed
timursaurus opened this issue Mar 7, 2023 · 2 comments · Fixed by #566
Closed

[BUG] [CCI] README Opensearch Logo missing #564

timursaurus opened this issue Mar 7, 2023 · 2 comments · Fixed by #566
Labels
bug Something isn't working CCI College Contributor Initiative

Comments

@timursaurus
Copy link
Contributor

Describe the bug

Opensearch logo file missing in readme.

Screenshot 2023-03-07 at 23 52 49

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/opensearch-project/oui#readme
  2. Clicking on the logo leads to a non-existing file.

Expected behavior
Opensearch logo should be displayed as in other repos such as the python repo.

Screenshot 2023-03-07 at 23 55 05

In the python repo, the logo file is stored at the root level and linked using an absolute path:

![OpenSearch logo](https://github.com/opensearch-project/opensearch-py/raw/main/OpenSearch.svg)

However, in the oui repo, the logo file is missing in the root level. The core repo links to an external file:

OpenSearch readme

<img src="https://opensearch.org/assets/img/opensearch-logo-themed.svg" height="64px">

Either way of linking the logo should work, but the missing file needs to be added for the first method to work.

Can I fix this and link to an external resource, like in the core repo?

@timursaurus timursaurus added bug Something isn't working untriaged labels Mar 7, 2023
@timursaurus timursaurus changed the title [BUG] README Opensearch Logo missing [BUG] [CCI] README Opensearch Logo missing Mar 7, 2023
@bl1nkker
Copy link

bl1nkker commented Mar 7, 2023

By the way, it is strange that such a problem exists 🤔

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Mar 9, 2023

By the way, it is strange that such a problem exists 🤔

Its likely the problem exists because OUI is a fork of another component library, and so are these files. We are working on alignment in approach across repos still.

@joshuarrrr joshuarrrr added the CCI College Contributor Initiative label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants