Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Docs) Key pad menu #200

Closed
5 of 8 tasks
Tracked by #112
KrooshalUX opened this issue Jan 6, 2023 · 2 comments · Fixed by #383
Closed
5 of 8 tasks
Tracked by #112

(OUI Docs) Key pad menu #200

KrooshalUX opened this issue Jan 6, 2023 · 2 comments · Fixed by #383
Assignees
Labels

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Jan 6, 2023

Section: Beta item

  • Change header "Beta item" to "Experimental item"

  • Change "If the item links to a module that is not GA (beta, lab, etc)" to "If the item links to a module that is not GA (experimental, lab, etc)"
    Update reference from Beta badge to Experiemental badge:

  • betaBadgeLabel to experimentalBadgeLabel

  • betaBadgeTooltipContent to experimentalBadgeTooltipContent

  • EuiBetaBadge to OuiExperimentalBadge

  • In the visual example, replace the "B" with the lab icon to reflect the guidance for Experimental badge

  • Remove "Supplying just a label will only show the first letter in the badge and supply the full label to the tooltip." as it is no longer in-line with Experimental badge guidance.

  • Change "You can also pass an iconType to replace the letter only badge and the label will still become the title." to "You can pass an iconType and the label will become the title."

@KrooshalUX KrooshalUX changed the title Key pad menu (OUI Docs) Key pad menu Jan 6, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Jan 6, 2023

For the beta badge ones, it might not make sense right this moment, because the experimental badge hasn't been implemented yet. #161 for tracking

@KrooshalUX
Copy link
Contributor Author

@BSFishy yes - I am not sure what we use to call out dependencies and blocking issues until they are do-able. I would consider this one blocked until OuiExperimentalBadge is available.

@BSFishy BSFishy added the documentation Improvements or additions to documentation label Jan 12, 2023
@KrooshalUX KrooshalUX added OUIDocs v2.6.0 and removed documentation Improvements or additions to documentation labels Jan 12, 2023
@KrooshalUX KrooshalUX removed their assignment Feb 21, 2023
@ashwin-pc ashwin-pc self-assigned this Feb 21, 2023
@ashwin-pc ashwin-pc linked a pull request Feb 21, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants