Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dart-sass instead of node-sass #160

Closed
BSFishy opened this issue Dec 15, 2022 · 3 comments
Closed

Use dart-sass instead of node-sass #160

BSFishy opened this issue Dec 15, 2022 · 3 comments

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Dec 15, 2022

Is your feature request related to a problem? Please describe.

node-sass is a deprecated module that is not very well maintained.

Describe the solution you'd like

node-sass should be replaced with dart-sass. dart-sass (or just plain sass on npm) is a newer pure Javascript implementation of Sass that is much better maintained and will support us better in the future. Dashboards has already made this change.

@BSFishy BSFishy added the enhancement New feature or request label Dec 15, 2022
@BSFishy
Copy link
Contributor Author

BSFishy commented Dec 15, 2022

This may need to be something we take care of when we revamp the theming system. Currently, we use sass-vars-to-js-loader, which has a dependency on node-sass. So we would either need to replace that (which it doesn't look like there is a good 1:1 replacement as of now) or wait until we don't need it anymore.

@ashwin-pc
Copy link
Member

A similar migration was mad in OSD for reference. opensearch-project/OpenSearch-Dashboards#2054

@BSFishy
Copy link
Contributor Author

BSFishy commented Oct 10, 2023

Finished in #1001

@BSFishy BSFishy closed this as completed Oct 10, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Look & Feel Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants