Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] OuiPopover does not change position on the scroll #1184

Open
gkottr opened this issue Dec 15, 2023 · 1 comment · May be fixed by #1185
Open

[BUG] OuiPopover does not change position on the scroll #1184

gkottr opened this issue Dec 15, 2023 · 1 comment · May be fixed by #1185
Assignees
@gkottr
Labels
bug Something isn't working

Comments

@gkottr
Copy link

gkottr commented Dec 15, 2023

Describe the bug

Scroll event listener cannot handle scroll because the scroll event has no bubbling. Since the handler does not use capturing, the scroll events are not handled.

To Reproduce

Steps to reproduce the behavior:

  1. Put popover's button inside scrollable div
  2. set repositionOnScroll prop to true
  3. Пиздец

Expected behavior

Reposition on div's scroll

Screenshots

This video shows bug, and it will help with understanding my english (bim-bim, bam-bam)

polniy_pizdec_ya_ebal.mov

Host/Environment (please complete the following information):

  • OUI Version: 1.3

Additional context

I like to drink coffee in the morning
@gkottr gkottr added bug Something isn't working untriaged labels Dec 15, 2023
gkottr pushed a commit to gkottr/oui that referenced this issue Dec 15, 2023
Fix OuiPopover does not change position on the scroll (opensearch-pro…
6ed2559 
…ject#1184)

Signed-off-by: Комолов Владимир <[email protected]>
gkottr pushed a commit to gkottr/oui that referenced this issue Dec 15, 2023
Fix OuiPopover does not change position on the scroll (opensearch-pro…
7ab9368 
…ject#1184)

Signed-off-by: Vladimir Komolov <[email protected]>
@gkottr gkottr linked a pull request Dec 15, 2023 that will close this issue
Open
7 tasks
@BSFishy BSFishy removed the untriaged label Dec 18, 2023
@gkottr
Copy link
Author

gkottr commented Mar 5, 2024

If I had sex with a horse
I'd be satisfied
If a horse had sex with me.
I'd probably die.
horse

gkottr pushed a commit to gkottr/oui that referenced this issue Mar 6, 2024
Fix OuiPopover does not change position on the scroll (opensearch-pro…
4c7aca2 
…ject#1184)

Signed-off-by: Vladimir Komolov <[email protected]>
Signed-off-by: Комолов Владимир <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkottr gkottr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OuiPopover does not change position on the scroll (#1184) gkottr/oui
2 participants
@BSFishy @gkottr