Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Polygon. Icon bug #1068

Open
canascar opened this issue Oct 9, 2023 · 6 comments · Fixed by #1083 · May be fixed by #1139
Open

[BUG] Polygon. Icon bug #1068

canascar opened this issue Oct 9, 2023 · 6 comments · Fixed by #1083 · May be fixed by #1139
Assignees
@joshuarrrr @BSFishy @willie-hung
Labels
bug Something isn't working good first issue Good for newcomers icons

Comments

@canascar
Copy link
Member

canascar commented Oct 9, 2023 •
edited
Loading

Describe the bug

Current Polygon icon SVG renders incorrectly.

To Reproduce
Steps to reproduce the behavior:
https://oui.opensearch.org/1.3/#/display/icons (Look for Polygon

Expected behavior

Items are filled when they should be empty.

Screenshots
Current Incorrect:
Screenshot 2023-10-09 at 9 14 58 AM

Should render correctly like below:
Screenshot 2023-10-09 at 9 19 34 AM

Replace with SVG below
polygon.zip
@canascar canascar added bug Something isn't working untriaged labels Oct 9, 2023
@canascar canascar added icons and removed untriaged labels Oct 9, 2023
@joshuarrrr joshuarrrr added the good first issue Good for newcomers label Oct 11, 2023
@willie-hung
Copy link
Contributor

willie-hung commented Oct 11, 2023 •
edited
Loading

Hi @joshuarrrr @BSFishy I would like to work on this issue. Thanks!

@willie-hung willie-hung mentioned this issue Oct 13, 2023
Merged
8 tasks
@canascar
Copy link
Member Author

canascar commented Nov 2, 2023

Sorry all - reopening this bug as there is a sizing issue on the icon. Here's the corrected version:
polygon.zip
@joshuarrrr, @BSFishy

@canascar canascar reopened this Nov 2, 2023
@willie-hung
Copy link
Contributor

willie-hung commented Nov 2, 2023 •
edited
Loading

Hi @canascar,
I've updated the SVG file in my local environment. However, the extra attributesclip-rule="evenodd" fill="#000" fill-rule="evenodd" is causing errors when updating snapshots. Should we adjust the snapshot testing tool to accommodate this single file or is there any workaround to update the snapshots.

@BSFishy
Copy link
Contributor

BSFishy commented Nov 2, 2023

I've updated the SVG file in my local environment. However, the extra propertiesclip-rule="evenodd" fill="#000" fill-rule="evenodd" is causing errors when updating snapshots. Should we adjust the snapshot testing tool to accommodate this single file or is there any workaround to update the snapshots.

I know for a fact the fill attribute should be removed. I think one of clip-rule or fill-rule can be removed too, but not sure. Test each one out, making sure it doesn't affect how the SVG looks, then I would recommend trying to update the snapshots again

@willie-hung willie-hung linked a pull request Nov 2, 2023 that will close this issue
Open
7 tasks
@willie-hung
Copy link
Contributor

Thanks @BSFishy! Just figure out the problem, when I changed the attributes from fill-rule to fillRule, the snapshot got updated 🤯. Additionally, I've removed any unnecessary attributes.

@canascar
Copy link
Member Author

canascar commented Nov 3, 2023

Thank you for working on this @Willie-The-Lord - please let me know if there are any other existing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuarrrr joshuarrrr

@BSFishy BSFishy

@willie-hung willie-hung

Labels
bug Something isn't working good first issue Good for newcomers icons
Projects
None yet
Milestone
No milestone
4 participants
@joshuarrrr @BSFishy @willie-hung @canascar