Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename crossInACircleFilled to crossInCircleFilled #1045

Closed
BSFishy opened this issue Sep 18, 2023 · 2 comments · Fixed by #1113
Closed

Rename crossInACircleFilled to crossInCircleFilled #1045

BSFishy opened this issue Sep 18, 2023 · 2 comments · Fixed by #1113
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Sep 18, 2023

https://opensearch.slack.com/archives/C05389T9LJC/p1695072084427309?thread_ts=1694535707.701519&cid=C05389T9LJC

The files should be renamed to not have the A and the icon type should be crossInCircleFilled but crossInACircleFilled should still point to crossInCircleFilled for backwards compatibility
@BSFishy BSFishy added enhancement New feature or request good first issue Good for newcomers labels Sep 18, 2023
@BSFishy BSFishy removed the untriaged label Sep 18, 2023
@Harshninave04 Harshninave04 mentioned this issue Sep 19, 2023
Closed
@kubabal
Copy link

kubabal commented Oct 11, 2023

I can take this on

@willie-hung willie-hung mentioned this issue Oct 24, 2023
Merged
7 tasks
@willie-hung
Copy link
Contributor

Hi @BSFishy @kubabal , it's a quick fix. I just do it right away to expedite the process. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@BSFishy @kubabal @willie-hung