From d2bea6f6d23a07e1bc9aacbb03eac45bc096444e Mon Sep 17 00:00:00 2001 From: Shenoy Pratik Date: Thu, 15 Aug 2024 21:27:40 -0700 Subject: [PATCH] Update styling for empty button and date picker icon (#1342) * update styling for empty button and date picker icon Signed-off-by: Shenoy Pratik * move line-height to empty button class Signed-off-by: Shenoy Pratik * update changelog Signed-off-by: Shenoy Pratik * remove specificity for QuickSelectPopover Signed-off-by: Shenoy Pratik * fix formatting in for calc Signed-off-by: Shenoy Pratik --------- Signed-off-by: Shenoy Pratik --- CHANGELOG.md | 1 + src/components/button/button_empty/_button_empty.scss | 1 + .../quick_select_popover/_quick_select_popover.scss | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ea6dd7669..013d711149 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ ### 🐛 Bug Fixes - Fixes combobox height with appendees ([#1338](https://github.com/opensearch-project/oui/pull/1338)) +- Update styling for empty button and date picker icon ([#1342](https://github.com/opensearch-project/oui/pull/1342)) ### 🚞 Infrastructure diff --git a/src/components/button/button_empty/_button_empty.scss b/src/components/button/button_empty/_button_empty.scss index d18a7bb3d1..a09c4566ce 100644 --- a/src/components/button/button_empty/_button_empty.scss +++ b/src/components/button/button_empty/_button_empty.scss @@ -25,6 +25,7 @@ animation: none !important; /* 1 */ transition-timing-function: ease-in; /* 2 */ transition-duration: $ouiAnimSpeedFast; /* 2 */ + line-height: inherit; .ouiButtonEmpty__content { padding: 0 $ouiSizeS; diff --git a/src/components/date_picker/super_date_picker/quick_select_popover/_quick_select_popover.scss b/src/components/date_picker/super_date_picker/quick_select_popover/_quick_select_popover.scss index c9e53c67c1..3a368bae3f 100644 --- a/src/components/date_picker/super_date_picker/quick_select_popover/_quick_select_popover.scss +++ b/src/components/date_picker/super_date_picker/quick_select_popover/_quick_select_popover.scss @@ -25,7 +25,7 @@ // sass-lint:disable no-important .ouiQuickSelectPopover__buttonText { // Override specificity from universal and sibling selectors - margin-right: $ouiSizeXS !important; + margin-right: calc($ouiSizeXS / 2) !important; } .ouiQuickSelectPopover__anchor {