From 5525ecd68daebc10e58da965f82722e8937b5038 Mon Sep 17 00:00:00 2001 From: "opensearch-trigger-bot[bot]" <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Date: Thu, 31 Aug 2023 09:56:48 -0700 Subject: [PATCH] change onDismissible to onDismiss (#1003) (#1008) (cherry picked from commit 38a6ea71e2b3f4cc7a94c31760ebdc375b9f0242) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --- src-docs/src/views/call_out/info.js | 2 +- .../call_out/__snapshots__/call_out.test.tsx.snap | 2 +- src/components/call_out/call_out.test.tsx | 6 +++--- src/components/call_out/call_out.tsx | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src-docs/src/views/call_out/info.js b/src-docs/src/views/call_out/info.js index 2afe71e4df..1cae19f035 100644 --- a/src-docs/src/views/call_out/info.js +++ b/src-docs/src/views/call_out/info.js @@ -26,7 +26,7 @@ export default () => { title="Callouts can be dismissed when dismissible is set to true unless the color is danger or warning. " iconType="wrench" dismissible - onDismissible={closeCallOut} + onDismiss={closeCallOut} /> ); } diff --git a/src/components/call_out/__snapshots__/call_out.test.tsx.snap b/src/components/call_out/__snapshots__/call_out.test.tsx.snap index 89a412f4ca..6043f67923 100644 --- a/src/components/call_out/__snapshots__/call_out.test.tsx.snap +++ b/src/components/call_out/__snapshots__/call_out.test.tsx.snap @@ -45,7 +45,7 @@ exports[`OuiCallOut props color warning is rendered 1`] = ` exports[`OuiCallOut props dismissible close callout after click 1`] = ` <OuiCallOut dismissible={true} - onDismissible={[MockFunction]} + onDismiss={[MockFunction]} title="This is a callout" > <div diff --git a/src/components/call_out/call_out.test.tsx b/src/components/call_out/call_out.test.tsx index 6f4d9aad9a..8e8db22de1 100644 --- a/src/components/call_out/call_out.test.tsx +++ b/src/components/call_out/call_out.test.tsx @@ -107,17 +107,17 @@ describe('OuiCallOut', () => { }); it('close callout after click', () => { - const onDismissible = jest.fn(); + const onDismiss = jest.fn(); const component = mount( <OuiCallOut dismissible={true} - onDismissible={onDismissible} + onDismiss={onDismiss} title="This is a callout" /> ); expect(component).toMatchSnapshot(); findTestSubject(component, 'closeCallOutButton').simulate('click'); - expect(onDismissible).toBeCalled(); + expect(onDismiss).toBeCalled(); }); }); }); diff --git a/src/components/call_out/call_out.tsx b/src/components/call_out/call_out.tsx index 24b796e89d..d91e33a783 100644 --- a/src/components/call_out/call_out.tsx +++ b/src/components/call_out/call_out.tsx @@ -50,7 +50,7 @@ export type OuiCallOutProps = CommonProps & size?: Size; heading?: Heading; dismissible?: boolean; - onDismissible?: ( + onDismiss?: ( event?: | React.KeyboardEvent<HTMLDivElement> | React.MouseEvent<HTMLButtonElement> @@ -83,7 +83,7 @@ export const OuiCallOut = forwardRef<HTMLDivElement, OuiCallOutProps>( className, heading, dismissible = false, - onDismissible = () => {}, + onDismiss = () => {}, ...rest }, ref: Ref<HTMLDivElement> @@ -114,7 +114,7 @@ export const OuiCallOut = forwardRef<HTMLDivElement, OuiCallOutProps>( dismissibleIcon = ( <OuiButtonIcon iconType="cross" - onClick={onDismissible} + onClick={onDismiss} className="ouiCallOut__closeIcon" aria-label="dismissible_icon" data-test-subj="closeCallOutButton"