-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Implement segment replication event cancellation. #4387
Merged
mch2
merged 1 commit into
opensearch-project:2.x
from
mch2:backport/backport-4225-to-2.x
Sep 2, 2022
Merged
[Backport 2.x] Implement segment replication event cancellation. #4387
mch2
merged 1 commit into
opensearch-project:2.x
from
mch2:backport/backport-4225-to-2.x
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Failing due to heap space issue. Tracked in #3973.
|
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
mch2
force-pushed
the
backport/backport-4225-to-2.x
branch
from
September 2, 2022 04:53
b0d892b
to
6818bda
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4387 +/- ##
============================================
+ Coverage 70.54% 70.68% +0.13%
- Complexity 56942 57146 +204
============================================
Files 4572 4584 +12
Lines 273816 274484 +668
Branches 40152 40223 +71
============================================
+ Hits 193170 194008 +838
+ Misses 64455 64263 -192
- Partials 16191 16213 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dreamer-89
approved these changes
Sep 2, 2022
@mch2 : Looks like a conflict, can you rebase and merge ? |
…n. (opensearch-project#4225) * Segment Replication. Fix Cancellation of replication events. This PR updates segment replication paths to correctly cancel replication events on the primary and replica. In the source service, any ongoing event for a primary that is sending to a replica that shuts down or is promoted as a new primary are cancelled. In the target service, any ongoing event for a replica that is promoted as a new primary or is fetching from a primary that shuts down. It wires up SegmentReplicationSourceService as an IndexEventListener so that it can respond to events and cancel any ongoing transfer state. This change also includes some test cleanup for segment replication to rely on actual components over mocks. Signed-off-by: Marc Handalian <[email protected]> Fix to not start/stop SegmentReplicationSourceService as a lifecycle component with feature flag off. Signed-off-by: Marc Handalian <[email protected]> Update logic to properly mark SegmentReplicationTarget as cancelled when cancel initiated by primary. Signed-off-by: Marc Handalian <[email protected]> Minor updates from self review. Signed-off-by: Marc Handalian <[email protected]> * Add missing changelog entry. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit 19d1a2b)
mch2
force-pushed
the
backport/backport-4225-to-2.x
branch
from
September 2, 2022 18:04
6818bda
to
1a9712c
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #4225 to 2.x.