[Backport 2.x] Do not fail replica shard due to primary closure #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
This commit prevents a replica shard from being failed in the case that a replication action to a replica is canceled due to the primary shard being closed. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 1dbb63a)
opensearch-trigger-bot
bot
requested review from
a team and
reta
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4309 +/- ##
============================================
- Coverage 70.66% 70.65% -0.02%
+ Complexity 56932 56924 -8
============================================
Files 4570 4571 +1
Lines 273527 273530 +3
Branches 40110 40111 +1
============================================
- Hits 193301 193266 -35
+ Misses 64071 64069 -2
- Partials 16155 16195 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
approved these changes
Aug 26, 2022
Signed-off-by: Andrew Ross <[email protected]>
andrross
force-pushed
the
backport/backport-4133-to-2.x
branch
from
ed2a606 to
ff1e80d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
Failure in SegmentReplicationTargetServiceTests. Can't reproduce locally, looks like a flaky test. Issue exists here: #4268 |
Gradle Check (Jenkins) Run Completed with:
|
Created #4312 for tracking this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1dbb63a from #4133