[Backport 2.2] Fix the bug that masterOperation(with task param) is bypassed #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
The method `protected void masterOperation(Task task, Request request, ClusterState state, ActionListener<Response> listener)` was not properly deprecated by the commit 2a1b239 / PR #403. There is a problem that it doesn't make any difference to whether overriding the method `void masterOperation(Task task, Request request, ClusterState state, ActionListener<Response> listener)` or not. The reason is the only usage for the method changed to call another method `clusterManagerOperation(task, request, clusterState, l)`, which is the default implementation for the method `masterOperation(with task param)`. There is no other usage for the method `masterOperation()` so it's bypassed. In the commit: - Change delegation model for method `clusterManagerOperation(with task param)` to call `masterOperation(with task param)`, according to the comment below #4103 (comment) - Add a test to validate the backwards compatibility, which copied and modified from an existing test. Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit 3ab0d1f)
opensearch-trigger-bot
bot
requested review from
a team and
reta
as code owners
tlfeng
added
bug
tlfeng
approved these changes
Aug 3, 2022
reta
approved these changes
Aug 3, 2022
Gradle Check (Jenkins) Run Completed with:
|
|
In build 1383: Added to issue #2064 |
Gradle Check (Jenkins) Run Completed with:
|
|
Build 1386 failed due to Java heap space |
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3ab0d1f from #4103
There is a problem that it doesn't make any difference to whether overriding the method
void masterOperation(Task task, Request request, ClusterState state, ActionListener<Response> listener)or not.clusterManagerOperation(with task param)to callmasterOperation(with task param), according to the comment below Fix the bug that masterOperation(with task param) is bypassed #4103 (comment)