Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly ignore depandabot branches during push #4077

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Aug 1, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Correctly ignore depandabot branches during push.
Per github document the single * will not ignore additional / if the branch name includes it.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

In this PR the branch name is: dependabot/gradle/com.diffplug.spotless-6.9.0 thus ignore rule.
#4065

Thanks.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added bug Something isn't working CI CI related cicd labels Aug 1, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner August 1, 2022 22:33
@peterzhuamazon peterzhuamazon self-assigned this Aug 1, 2022
@peterzhuamazon peterzhuamazon requested a review from reta as a code owner August 1, 2022 22:33
@peterzhuamazon peterzhuamazon added backport 1.x backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 1.3 Backport to 1.3 branch backport 2.1 labels Aug 1, 2022
@peterzhuamazon peterzhuamazon requested a review from CEHENKLE August 1, 2022 22:34
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4077 (615c3e8) into main (6f43dbc) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #4077      +/-   ##
============================================
- Coverage     70.61%   70.54%   -0.07%     
- Complexity    56983    56995      +12     
============================================
  Files          4595     4595              
  Lines        274234   274234              
  Branches      40181    40181              
============================================
- Hits         193638   193466     -172     
- Misses        64342    64503     +161     
- Partials      16254    16265      +11     
Impacted Files Coverage Δ
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
.../java/org/opensearch/snapshots/RestoreService.java 55.37% <0.00%> (ø)
...org/opensearch/cluster/metadata/IndexMetadata.java 83.85% <100.00%> (ø)
.../main/java/org/opensearch/index/IndexSettings.java 86.35% <100.00%> (ø)
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...gations/bucket/composite/CompositeAggregation.java 15.00% <0.00%> (-85.00%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 41.37% <0.00%> (-58.63%) ⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-55.00%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 55.00% <0.00%> (-45.00%) ⬇️
...aggregations/bucket/composite/ParsedComposite.java 44.44% <0.00%> (-40.75%) ⬇️
... and 477 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit 27c5493 into opensearch-project:main Aug 3, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-gradle-check-ingore-fix-2 branch August 3, 2022 18:48
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)
@kartg kartg added the backport 2.2 Backport to 2.2 branch label Aug 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)
kartg pushed a commit that referenced this pull request Aug 4, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)

Co-authored-by: Peter Zhu <[email protected]>
kartg pushed a commit that referenced this pull request Aug 5, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)

Co-authored-by: Peter Zhu <[email protected]>
kartg pushed a commit that referenced this pull request Aug 5, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)

Co-authored-by: Peter Zhu <[email protected]>
kartg pushed a commit that referenced this pull request Aug 5, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)

Co-authored-by: Peter Zhu <[email protected]>
Rishikesh1159 pushed a commit that referenced this pull request Oct 6, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)

Co-authored-by: Peter Zhu <[email protected]>
Rishikesh1159 pushed a commit that referenced this pull request Oct 11, 2022
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 27c5493)

Co-authored-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 2.1 backport 2.2 Backport to 2.2 branch bug Something isn't working CI CI related cicd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants