-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate class FakeThreadPoolMasterService, BlockMasterServiceOnMaster and BusyMasterServiceDisruption, in 'test/framework' directory #4058
Conversation
…er and BusyMasterServiceDisruption Signed-off-by: Tianli Feng <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
In build 1154:
Not related to the code change in this PR. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@kotwanikunal Thanks a lot for your review! 👍 |
…er and BusyMasterServiceDisruption (#4058) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR #4051, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit cebeb8c)
…er and BusyMasterServiceDisruption (#4058) (#4068) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR #4051 / commit bea5d1a, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit cebeb8c) Co-authored-by: Tianli Feng <[email protected]>
Created issue #4069 to track this |
…er and BusyMasterServiceDisruption (opensearch-project#4058) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR opensearch-project#4051, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <[email protected]>
Description
To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base.
In a previous PR #4051 / commit bea5d1a, 3 classes in
test/framework
directory that containsmaster
in the name were renamed:This is a following PR to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes.
Issues Resolved
A part of issue #3543
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.