[Backport 2.x] Parallelize stale blobs deletion during snapshot delete #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Parallelize stale blobs deletion during snapshot delete Signed-off-by: Piyush Daftary <[email protected]> * Adding test which throws exception Signed-off-by: Piyush Daftary <[email protected]> * Adusting identation for spotlessJavaCheck Signed-off-by: Piyush Daftary <[email protected]> * Adding more description to MAX_SHARD_BLOB_DELETE_BATCH_SIZE Signed-off-by: Piyush Daftary <[email protected]> * Renaming max_shard_blob_delete_batch_size to max_snapshot_shard_blob_delete_batch_size Signed-off-by: Piyush Daftary <[email protected]> (cherry picked from commit 1c787e8)
dreamer-89
approved these changes
Jul 22, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #3990 +/- ##
============================================
- Coverage 70.63% 70.57% -0.07%
- Complexity 56487 56797 +310
============================================
Files 4527 4573 +46
Lines 271798 273476 +1678
Branches 39975 40101 +126
============================================
+ Hits 191985 193000 +1015
- Misses 63718 64238 +520
- Partials 16095 16238 +143
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Gradle Check (Jenkins) Run Completed with:
|
VachaShah
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1c787e8 from #3796