Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Moving RecoveryState.Index to a top-level class and renaming #3971

Conversation

Rishikesh1159
Copy link
Member

Signed-off-by: Rishikesh1159 [email protected]

Description

This PR backports PR to 2.x branch and resolve conflict in RecoveryState class.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Rishikesh1159 Rishikesh1159 requested review from a team and reta as code owners July 21, 2022 17:20
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I validated the change is the same with the original PR, and RecoveryState class is used internally and not used by other plugins.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #3971 (c950c34) into 2.x (da244c2) will decrease coverage by 0.12%.
The diff coverage is 75.42%.

@@             Coverage Diff              @@
##                2.x    #3971      +/-   ##
============================================
- Coverage     70.65%   70.53%   -0.13%     
- Complexity    56401    56429      +28     
============================================
  Files          4526     4527       +1     
  Lines        271757   271758       +1     
  Branches      39979    39976       -3     
============================================
- Hits         192000   191674     -326     
- Misses        63578    63957     +379     
+ Partials      16179    16127      -52     
Impacted Files Coverage Δ
...g/opensearch/indices/recovery/MultiFileWriter.java 83.83% <ø> (ø)
...java/org/opensearch/index/shard/StoreRecovery.java 67.82% <50.00%> (-0.35%) ⬇️
...ch/indices/recovery/PeerRecoveryTargetService.java 52.36% <50.00%> (ø)
...org/opensearch/indices/recovery/RecoveryState.java 56.88% <66.66%> (-9.87%) ⬇️
...ces/replication/common/ReplicationLuceneIndex.java 75.87% <75.87%> (ø)
...rg/opensearch/indices/recovery/RecoveryTarget.java 75.41% <100.00%> (ø)
...java/org/opensearch/client/indices/DataStream.java 0.00% <0.00%> (-76.09%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 17.50% <0.00%> (-73.75%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-62.50%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
... and 543 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Rishikesh1159 Rishikesh1159 merged commit c0b1b59 into opensearch-project:2.x Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants