-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Segment Replication] Moving RecoveryState.Index to a top-level class and renaming #3971
[Backport 2.x] [Segment Replication] Moving RecoveryState.Index to a top-level class and renaming #3971
Conversation
…n RecoveryState class Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I validated the change is the same with the original PR, and RecoveryState
class is used internally and not used by other plugins.
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #3971 +/- ##
============================================
- Coverage 70.65% 70.53% -0.13%
- Complexity 56401 56429 +28
============================================
Files 4526 4527 +1
Lines 271757 271758 +1
Branches 39979 39976 -3
============================================
- Hits 192000 191674 -326
- Misses 63578 63957 +379
+ Partials 16179 16127 -52
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Rishikesh1159 [email protected]
Description
This PR backports PR to 2.x branch and resolve conflict in RecoveryState class.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.