-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Don't run EmptyDirTaskTests in a Docker container #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't run EmptyDirTaskTests in a Docker container Signed-off-by: Daniel Widdis <[email protected]> * Catch possible exceptions Signed-off-by: Daniel Widdis <[email protected]> * Fix newlines with spotless Signed-off-by: Daniel Widdis <[email protected]> * Add comments explaining test incompatibilities Signed-off-by: Daniel Widdis <[email protected]> * IDE incorrectly removed needed imports Signed-off-by: Daniel Widdis <[email protected]> * Manual edit missed a duplicate Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit c526b0c)
owaiskazi19
approved these changes
Jul 14, 2022
reta
approved these changes
Jul 14, 2022
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Re-ran the gradle check, because the commit 21c45a5 has been merged |
dreamer-89
approved these changes
Jul 15, 2022
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #3912 +/- ##
============================================
- Coverage 70.64% 70.60% -0.05%
+ Complexity 56398 56390 -8
============================================
Files 4520 4515 -5
Lines 271675 271419 -256
Branches 39974 39958 -16
============================================
- Hits 191932 191634 -298
- Misses 63605 63678 +73
+ Partials 16138 16107 -31
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c526b0c from #3792