Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Don't run EmptyDirTaskTests in a Docker container #3912

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c526b0c from #3792

* Don't run EmptyDirTaskTests in a Docker container

Signed-off-by: Daniel Widdis <[email protected]>

* Catch possible exceptions

Signed-off-by: Daniel Widdis <[email protected]>

* Fix newlines with spotless

Signed-off-by: Daniel Widdis <[email protected]>

* Add comments explaining test incompatibilities

Signed-off-by: Daniel Widdis <[email protected]>

* IDE incorrectly removed needed imports

Signed-off-by: Daniel Widdis <[email protected]>

* Manual edit missed a duplicate

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit c526b0c)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners July 14, 2022 20:20
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@tlfeng
Copy link
Collaborator

tlfeng commented Jul 15, 2022

* What went wrong:
Execution failed for task ':distribution:bwc:maintenance:buildBwcLinuxTar'.
> Building 1.3.4 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/maintenance/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.4-SNAPSHOT-linux-x64.tar.gz

Re-ran the gradle check, because the commit 21c45a5 has been merged

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #3912 (7e7d232) into 2.x (ea55054) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #3912      +/-   ##
============================================
- Coverage     70.64%   70.60%   -0.05%     
+ Complexity    56398    56390       -8     
============================================
  Files          4520     4515       -5     
  Lines        271675   271419     -256     
  Branches      39974    39958      -16     
============================================
- Hits         191932   191634     -298     
- Misses        63605    63678      +73     
+ Partials      16138    16107      -31     
Impacted Files Coverage Δ
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
.../opensearch/search/profile/ProfileShardResult.java 28.57% <0.00%> (-60.72%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-58.54%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 55.55% <0.00%> (-44.45%) ⬇️
...indices/readonly/TransportAddIndexBlockAction.java 20.68% <0.00%> (-41.38%) ⬇️
...ile/aggregation/AggregationProfileShardResult.java 55.55% <0.00%> (-40.75%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
.../admin/indices/readonly/AddIndexBlockResponse.java 0.00% <0.00%> (-37.50%) ⬇️
... and 465 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea55054...7e7d232. Read the comment docs.

@owaiskazi19 owaiskazi19 merged commit 6841abd into 2.x Jul 15, 2022
@github-actions github-actions bot deleted the backport/backport-3792-to-2.x branch July 15, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants