Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixing implausibly old time stamp 1970-01-01 00:00:00 by using the timestamp from the Git revision instead of default 0 value #3891

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f165845 from #3883

…mestamp from the Git revision instead of default 0 value (#3883)

* Fixing implausibly old time stamp 1970-01-01 00:00:00 by using the timestamp from the Git revision instead of default 0 value

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments (encapsulating the Git origin date inside build script

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit f165845)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners July 13, 2022 20:37
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #3891 (f165845) into 2.x (6024f10) will decrease coverage by 0.02%.
The diff coverage is 68.00%.

❗ Current head f165845 differs from pull request most recent head 953e7e3. Consider uploading reports for the commit 953e7e3 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #3891      +/-   ##
============================================
- Coverage     70.53%   70.51%   -0.03%     
- Complexity    56324    56619     +295     
============================================
  Files          4520     4557      +37     
  Lines        271633   272732    +1099     
  Branches      39972    40044      +72     
============================================
+ Hits         191602   192305     +703     
- Misses        63870    64185     +315     
- Partials      16161    16242      +81     
Impacted Files Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java 0.00% <0.00%> (ø)
...nsearch/gradle/precommit/LicenseHeadersTask.groovy 0.00% <ø> (ø)
.../java/org/opensearch/gradle/JdkDownloadPlugin.java 37.36% <0.00%> (ø)
...ensearch/gradle/precommit/FilePermissionsTask.java 78.78% <ø> (ø)
...search/gradle/precommit/ForbiddenPatternsTask.java 88.40% <ø> (ø)
...g/opensearch/gradle/precommit/LoggerUsageTask.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% <0.00%> (ø)
...ensearch/gradle/tar/SymbolicLinkPreservingTar.java 0.00% <0.00%> (ø)
...a/org/opensearch/gradle/test/DistroTestPlugin.java 0.00% <ø> (ø)
...g/opensearch/gradle/test/rest/CopyRestApiTask.java 0.00% <ø> (ø)
... and 758 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe6461...953e7e3. Read the comment docs.

@andrross andrross merged commit 22c5768 into 2.x Jul 13, 2022
@github-actions github-actions bot deleted the backport/backport-3883-to-2.x branch July 13, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants