Introducing TranslogManager implementations decoupled from the Engine [2.x] #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bukhtawar Khan <[email protected]>
Signed-off-by: Bukhtawar Khan <[email protected]>
Signed-off-by: Bukhtawar Khan <[email protected]>
Signed-off-by: Bukhtawar Khan <[email protected]>
Signed-off-by: Bukhtawar Khan <[email protected]>
Signed-off-by: Satyajit Ganguly <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #3820 +/- ##
======================================
Coverage ? 70.59%
Complexity ? 56387
======================================
Files ? 4520
Lines ? 271632
Branches ? 39972
======================================
Hits ? 191772
Misses ? 63738
Partials ? 16122 Continue to review full report at Codecov.
|
reta
requested changes
Jul 8, 2022
The breaking changes done in |
reta
reviewed
Jul 8, 2022
| @@ -828,7 +828,7 @@ protected final void ensureOpen(Exception suppressed) { | |||
| } | |||
| } | |||
|
|
|||
| protected final void ensureOpen() { | |||
| public final void ensureOpen() { | |||
There was a problem hiding this comment.
@satyajitg28 this is a breaking change: the change in visibly breaks compilation, it is not reverted sorry, messed up the change diff should be fine
reta
approved these changes
Jul 8, 2022
Bukhtawar
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing TranslogManager implementations decoupled from the Engine (keeping Engine backward compatible)
Here is the Original CR
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.