Upgrade minio image version #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
added
backport 2.x
|
✅ Gradle Check success 72b9b8ec6bc85d5a961ad745cc6dee29144fa080 |
reta
approved these changes
Jun 8, 2022
saratvemulapalli
approved these changes
Jun 8, 2022
saratvemulapalli
added
>upgrade
|
@lukas-vlcek CI's are good. Are you good to merge this change? |
|
@saratvemulapalli FYI: I will get back to this tomorrow. |
On top of that addressing MinIO warning: - setup ulimits - use of static console port - do not use deprecated argument names With regard to static ports this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case). Closes opensearch-project#3539 Signed-off-by: Lukáš Vlček <[email protected]>
lukas-vlcek
force-pushed
the
3539_minio_upgrade
branch
from
72b9b8e to
7a0cb04
Compare
|
I pushed an update. It is ready for review :-) Still I am asking myself if it would be ok to switch to the LATEST image instead of fixed version. WDYT? |
nknize
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
This LGTM. @saratvemulapalli want to have a final check and merge?
Rishikesh1159
added
v2.2.0
and removed
v2.1.0
|
@reta I've dropped labels to backport to 2.0, 2.1 since they are already out. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
On top of that addressing MinIO warning: - setup ulimits - use of static console port - do not use deprecated argument names With regard to static ports this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case). Closes #3539 Signed-off-by: Lukáš Vlček <[email protected]> (cherry picked from commit 9af3407)
reta
pushed a commit
that referenced
this pull request
Jul 13, 2022
On top of that addressing MinIO warning: - setup ulimits - use of static console port - do not use deprecated argument names With regard to static ports this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case). Closes #3539 Signed-off-by: Lukáš Vlček <[email protected]> (cherry picked from commit 9af3407) Co-authored-by: Lukáš Vlček <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukáš Vlček [email protected]
Description
Upgrading minio image to new version (the previous one was 3 years old).
On top of that addressing MinIO warning:
With regard to static port this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html
We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case).
A minor note: the third service in docker-compose was using a bit different indentation - fixing it.
Issues Resolved
Closes #3539
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.