Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation on FlintSpark Optimistic Transaction #953

Open
noCharger opened this issue Nov 27, 2024 · 2 comments
Open

Limitation on FlintSpark Optimistic Transaction #953

noCharger opened this issue Nov 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@noCharger
Copy link
Collaborator

noCharger commented Nov 27, 2024

Is your feature request related to a problem?

When transaction fails, the only action item taken is to rollback the metadata log entry. This could cause partial failures like #826. Furthermore, if the flint data index is accidentally deleted, the refreshIndex API will always fail, but the user is unaware of this because the index state has been rolled back.

What solution would you like?

Short term solution:

  1. External scheduler should check the index state before fire the subsequent query

Long term solution:

  1. Enhance rollback logic to handle partial failure. Enhance prepare() to consider other components which related to state.
  2. Introduce a corrupted state and may recover the index deleted
@noCharger noCharger added enhancement New feature or request untriaged labels Nov 27, 2024
@noCharger
Copy link
Collaborator Author

Regarding to 2. on long term solution, we got another feedback from Nitish that we should re create the index in such cases and customer should delete the dashboard if they no more want the refreshes to happen. Any thoughts on this? @anasalkouz @penghuo @dai-chen

@dblock dblock removed the untriaged label Dec 16, 2024
@dblock
Copy link
Member

dblock commented Dec 16, 2024

[Catch All Triage - 1, 2, 3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants