Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Deprecate implicitly nullable parameter type in ringphp #242

Open
dmnlk opened this issue Dec 7, 2024 · 5 comments
Open

[BUG]Deprecate implicitly nullable parameter type in ringphp #242

dmnlk opened this issue Dec 7, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@dmnlk
Copy link

dmnlk commented Dec 7, 2024

The change "Deprecate implicitly nullable parameter types" was introduced in PHP 8.4. This means that if a parameter's default value is set to null, its type declaration must explicitly include null or be nullable using a union type.

This issue also exists in the ezimuel/ringphp library that this project depends on. However, ezimuel/ringphp appears to be inactive, as it is a fork of the original library.

How should we address this situation?

ezimuel/ringphp#13

@dmnlk dmnlk added bug Something isn't working untriaged labels Dec 7, 2024
@dmnlk dmnlk changed the title [BUG] Deprecate implicitly nullable parameter types  in ringphp [BUG]Deprecate implicitly nullable parameter type in ringphp Dec 7, 2024
@dblock
Copy link
Member

dblock commented Dec 7, 2024

There's a PR in progress in #233 to get rid of ringphp, any help there would be appreciated.

@dblock dblock removed the untriaged label Dec 9, 2024
@dmnlk
Copy link
Author

dmnlk commented Dec 11, 2024

I think it’s a great initiative to move away from ringphp. However, I believe it could be a challenging and time-consuming effort. Do you have any temporary solutions or workarounds in mind?

@dblock
Copy link
Member

dblock commented Dec 11, 2024

I think it’s a great initiative to move away from ringphp. However, I believe it could be a challenging and time-consuming effort. Do you have any temporary solutions or workarounds in mind?

AFAIK there aren't any

@glo71317
Copy link

@dblock It seems it is blocker to upgrade PHP 8.4 So, Are we working on any workaround or any discussion in progress regarding the same to mitigate this?

@dblock
Copy link
Member

dblock commented Dec 16, 2024

There are no workarounds for this AFAIK, so #233 is it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants