Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #28

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 14 comments · Fixed by #39
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #28

dblock opened this issue Feb 14, 2023 · 14 comments · Fixed by #39
Assignees

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@dblock
Copy link
Member Author

dblock commented Mar 23, 2023

Permissions are incorrect. You have 28+ people with admin access. Please work with admin to fix.

Screenshot 2023-03-23 at 10 59 10 AM

@dblock dblock reopened this Mar 23, 2023
@anasalkouz
Copy link
Member

anasalkouz commented Mar 30, 2023

@samuel-oci, could you please revoke admin access from clients group?

@sam-herman
Copy link
Collaborator

Hi @anasalkouz , I don't think I have the capability to do so at the moment, perhaps I need to be able another permission to see all other admins?
image

@anasalkouz
Copy link
Member

@dblock Could you please help on this? neither I nor @samuel-oci has access.

@dblock
Copy link
Member Author

dblock commented Apr 4, 2023

@bbarani I don't have access either, help?

@bbarani
Copy link
Member

bbarani commented Apr 4, 2023

I am not seeing the setting tab to view the current list of maintainers as well. @samuel-oci can you try to add the team @opensearch-project/admin team as admin user? I will reach out to the OpenSearch repository orgnaization owners if you are not able to do it.

@wbeckler
Copy link

wbeckler commented Apr 7, 2023

@CEHENKLE @hyandell Can one of you change the @opensearch-project/admin team hear to Admin access rather than Read access, as appears in DB's screenshot above. I think this requires repo-level admin privileges as nobody has admin in this repo.

@hyandell
Copy link

hyandell commented Apr 7, 2023

@admin changed to have Admin perms.

@wbeckler
Copy link

wbeckler commented Apr 7, 2023

I added the named maintainers as maintainers in the guithub permssions. @samuel-oci can you take a look and confirm the changes are okay?

@peternied
Copy link
Member

Screenshot: image

@anasalkouz anasalkouz self-assigned this Apr 7, 2023
@sam-herman
Copy link
Collaborator

sam-herman commented Apr 8, 2023 via email

@anasalkouz
Copy link
Member

@peternied changes looks good to me.

@anasalkouz
Copy link
Member

I think we can resolve the issue now.

@dblock
Copy link
Member Author

dblock commented Apr 13, 2023

Thanks, verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants