Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Don't run tests on PRs with doc changes only #438

Closed
kavilla opened this issue Mar 17, 2023 · 1 comment · Fixed by #441
Closed

[CI] Don't run tests on PRs with doc changes only #438

kavilla opened this issue Mar 17, 2023 · 1 comment · Fixed by #441
Labels
CCI College Contributor Initiative good first issue Good for newcomers

Comments

@kavilla
Copy link
Member

kavilla commented Mar 17, 2023

Example: #436

This PR runs the tests even though there are only documentation changes. This can cause unnecessary runs and add to a large queue for no reason.

OpenSearch Dashboards repo skips on doc changes like:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/build_and_test_workflow.yml#L10
@kavilla kavilla added untriaged good first issue Good for newcomers and removed untriaged labels Mar 17, 2023
@kavilla
Copy link
Member Author

kavilla commented Mar 17, 2023

@Wielmany I see you are tackling issues related to the doc and it's really awesome.

Did you want to pick this one up should be a quick win? So your PRs aren't blocked waiting for tests when it's for updates to markdown files.

@kavilla kavilla removed the untriaged label Mar 17, 2023
@Wielmany Wielmany mentioned this issue Mar 17, 2023
Merged
@nhtruong nhtruong added the CCI College Contributor Initiative label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CCI College Contributor Initiative good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CCI] Don't run tests on PRs with doc changes only Wielmany/opensearch-js
2 participants
@nhtruong @kavilla