Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow setting an arbitrary json property on any level of any API request objects #379

Open
L00kian opened this issue Feb 28, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@L00kian
Copy link
Contributor

L00kian commented Feb 28, 2023

Is your feature request related to a problem?

Current Java API doesn't contain definition of 'mapping' object within org.opensearch.client.opensearch.indices.IndexSettings and doesn't allow a non-declared json field to be added to the payload

What solution would you like?

Either add mapping.totalFields.limit properties chain to IndexSettings object or consider allowing setting an arbitrary json property on any level of any API request objects

What alternatives have you considered?

Using high-level rest client as a workaround

Do you have any additional context?

Nope

@L00kian L00kian added enhancement New feature or request untriaged labels Feb 28, 2023
@dblock
Copy link
Member

dblock commented Feb 28, 2023

Looks right, want to contribute @L00kian ?

@dblock dblock removed the untriaged label Feb 28, 2023
@L00kian
Copy link
Contributor Author

L00kian commented Mar 1, 2023

Hi @dblock, which option would be the way to go? arbitrary fields support on all the levels or just adding the field?

Can and will contribute :)

@dblock
Copy link
Member

dblock commented Mar 1, 2023

Both! I think that arbitrary fields support on all the levels makes some sense because it will provide a workaround quickly, but that also means that one could theoretically add fields that don't exist. I would fix any missing field as 1 PR and then independently propose an arbitrary field solution and we can discuss that on its own merits. WDYT?

@VachaShah VachaShah added the good first issue Good for newcomers label Mar 1, 2023
@wbeckler wbeckler changed the title [FEATURE] java api doesn't allow setting index.mapping.total_fields.limit [FEATURE] allow setting an arbitrary json property on any level of any API request objects Oct 3, 2023
@wbeckler
Copy link

wbeckler commented Oct 3, 2023

I'm renaming this issue to refer to the remaining proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants