Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compatibility matrix is missing compatible server versions #285

Closed
wbeckler opened this issue Dec 1, 2022 · 5 comments · Fixed by #367
Closed

[BUG] Compatibility matrix is missing compatible server versions #285

wbeckler opened this issue Dec 1, 2022 · 5 comments · Fixed by #367
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@wbeckler
Copy link

wbeckler commented Dec 1, 2022

What is the bug?

There is no mention of server version 2.4 here: https://github.com/opensearch-project/opensearch-java/blob/main/COMPATIBILITY.md

It would also be useful to know whether the client can work with older versions of opensearch or elasticsearch, so people can know if they can upgrade their client before upgrading their server.

@wbeckler wbeckler added bug Something isn't working untriaged documentation Improvements or additions to documentation and removed untriaged labels Dec 1, 2022
@andrross
Copy link
Member

It looks like this has gotten more stale...there's no mention of server 2.4 or 2.5, nor is there a mention of client 2.2.0.

@AmiStrn
Copy link
Contributor

AmiStrn commented Feb 15, 2023

This is alarming since I was just about to write an implementation using this client. How is it being tested against the latest versions?

@dblock
Copy link
Member

dblock commented Feb 15, 2023

Server is following semver, so I don't expect anything to break. We are running integration tests against a matrix in https://github.com/opensearch-project/opensearch-java/blob/main/.github/workflows/test-integration.yml#L19, let's add 2.4 and update the docs. @AmiStrn if you want to beat me to this PR, go for it! @wbeckler I think we need to schedule this work with every release of OpenSearch so we're not behind.

@AmiStrn
Copy link
Contributor

AmiStrn commented Feb 16, 2023

Timezones... sure @dblock ill make the changes :)

@AmiStrn
Copy link
Contributor

AmiStrn commented Feb 17, 2023

@dblock I made the quick change:) thanks for clearing this up for us. ran the tests locally and nothing broke.

@reta reta closed this as completed in #367 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants