Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][2.10] conflicts in cypress commands #834

Closed
kavilla opened this issue Sep 8, 2023 · 1 comment · Fixed by #835
Closed

[BUG][2.10] conflicts in cypress commands #834

kavilla opened this issue Sep 8, 2023 · 1 comment · Fixed by #835
Labels
bug Something isn't working v2.10.0

Comments

@kavilla
Copy link
Member

kavilla commented Sep 8, 2023 •
edited
Loading

#826 overwritten functions that other tests are using causing failures.

Will need to either revert or address the conflicts within this file: https://github.com/amsiglan/opensearch-dashboards-functional-test/blob/45104b809fe1eeeb137301b168cc24d63d42055b/cypress/utils/plugins/security-analytics-dashboards-plugin/commands.js

For example: the request, overwrites:

https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/2.x/cypress/utils/commands.js#L67 and wipes out the header.

An empty xsrf token will likely cause failures for all requests to OSD.
@kavilla kavilla added bug Something isn't working untriaged v2.10.0 and removed untriaged labels Sep 8, 2023
@kavilla kavilla removed the untriaged label Sep 8, 2023
@kavilla
Copy link
Member Author

kavilla commented Sep 8, 2023

@amsiglan lemme know if you are able to look into this

@kavilla kavilla mentioned this issue Sep 8, 2023
Merged
1 task
@amsiglan amsiglan mentioned this issue Sep 8, 2023
Merged
1 task
@kavilla kavilla linked a pull request Sep 8, 2023 that will close this issue
Updated cypress commands to avoid duplication #835
Merged
1 task
@kavilla kavilla closed this as completed Sep 8, 2023
@kavilla kavilla mentioned this issue Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated cypress commands to avoid duplication amsiglan/opensearch-dashboards-functional-test
1 participant
@kavilla