-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace alpha1 with rc1. #1863
Replace alpha1 with rc1. #1863
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
=========================================
Coverage 94.46% 94.46%
Complexity 22 22
=========================================
Files 179 179
Lines 3649 3649
Branches 29 29
=========================================
Hits 3447 3447
Misses 196 196
Partials 6 6 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big change means a lot of the repos needs to change their ci as well.
Will block this until we clear up the confusion and final decision.
Thanks.
We will merge this PR once we have the working build with alpha qualifier. |
This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1. |
Signed-off-by: dblock <[email protected]>
Once this is merged, the |
So just to confirm you will send PR to all the plugin repos to change alpha1 to rc1 after build success, right? |
Yes, that's what I am saying. |
@peterzhuamazon We have to merge this and ensure at least 1 successful RC1 SNAPSHOT build before we go PR changes in all plugins, otherwise their CIs will start failing because there's no opensearch-min-SNAPSHOT. |
@dblock I approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprise no conflict but shouldn't be a big deal.
Can we get this merged in otherwise OpenSearch Dashboards sanity tests will fail.
Signed-off-by: dblock [email protected]
Description
Replace alpha1 with rc1. We're doing away with alpha.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.